Page MenuHomePhabricator

AMDGPU/GlobalISel: Allow arbitrary global values
ClosedPublic

Authored by arsenm on Feb 17 2020, 6:28 AM.

Details

Summary

Treat unknown address spaces as global

Diff Detail

Event Timeline

arsenm created this revision.Feb 17 2020, 6:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 17 2020, 6:28 AM
rampitec added inline comments.Feb 17 2020, 9:48 AM
llvm/lib/Target/AMDGPU/SIISelLowering.h
266

The function name is misleading, private is also non-global.

arsenm updated this revision to Diff 245009.Feb 17 2020, 10:36 AM

Fail on private globals

This revision is now accepted and ready to land.Feb 17 2020, 11:19 AM