Page MenuHomePhabricator

[DebugInfo] Print version in error message in decimal
ClosedPublic

Authored by jhenderson on Tue, Feb 11, 6:19 AM.

Details

Summary

Also remove some test duplication and add a test case that shows the maximum version is rejected (this shows that the value in the error message is actually in decimal, and not just missing an 0x prefix).

Diff Detail

Event Timeline

jhenderson created this revision.Tue, Feb 11, 6:19 AM
Herald added a project: Restricted Project. · View Herald Transcript
dblaikie accepted this revision.Tue, Feb 11, 9:56 AM

Looks good - thanks!

This revision is now accepted and ready to land.Tue, Feb 11, 9:56 AM
This revision was automatically updated to reflect the committed changes.