This is an archive of the discontinued LLVM Phabricator instance.

[MLIR][Affine] NFC: Move AffineValueMap and MutableAffineMap
ClosedPublic

Authored by flaub on Feb 8 2020, 1:31 AM.

Details

Summary

The AffineValueMap is moved into Dialect/AffineOps to prevent a cyclic
dependency between Analysis and Dialect/AffineOps.

Diff Detail

Event Timeline

flaub created this revision.Feb 8 2020, 1:31 AM
Herald added a project: Restricted Project. · View Herald Transcript
flaub updated this revision to Diff 243354.Feb 8 2020, 1:51 AM
  • Fix example
Harbormaster failed remote builds in B46016: Diff 243354!
flaub updated this revision to Diff 243355.Feb 8 2020, 1:53 AM

arcanist

There is a bunch of refactoring around AffineValueMap and MutableAffineMap, can you pull this out in a NFC parent revision?

mehdi_amini added inline comments.Feb 8 2020, 9:45 AM
mlir/include/mlir/Dialect/AffineOps/AffineOps.td
277 ↗(On Diff #243355)

represents a hyper-rectangular affine parallel band ?

flaub updated this revision to Diff 243401.Feb 8 2020, 12:34 PM
  • Split
flaub retitled this revision from [MLIR][Affine] Add affine.parallel op to [MLIR][Affine] NFC: Move AffineValueMap and MutableAffineMap .Feb 8 2020, 12:37 PM
flaub edited the summary of this revision. (Show Details)
mehdi_amini accepted this revision.Feb 8 2020, 12:43 PM

Thanks!

flaub added a comment.Feb 8 2020, 12:51 PM

The original diff included the AffineParallelOp, but this has been split out into its own diff based on this one: https://reviews.llvm.org/D74288

rriddle accepted this revision.Feb 9 2020, 10:44 PM
rriddle added inline comments.
mlir/lib/Dialect/AffineOps/AffineValueMap.cpp
76

We can drop the inline keywords now.

This revision is now accepted and ready to land.Feb 9 2020, 10:44 PM
flaub marked an inline comment as done.Feb 10 2020, 12:30 AM
flaub added inline comments.
mlir/lib/Dialect/AffineOps/AffineValueMap.cpp
76

Should we drop them from headers too? (IIUC, they're just hints and they are redundant if the definition is already in a header).

flaub marked an inline comment as not done.Feb 10 2020, 12:34 AM
flaub updated this revision to Diff 243482.Feb 10 2020, 1:46 AM
flaub retitled this revision from [MLIR][Affine] NFC: Move AffineValueMap and MutableAffineMap to [MLIR][Affine] NFC: Move AffineValueMap and MutableAffineMap.

Remove inline

This revision was automatically updated to reflect the committed changes.