This is an archive of the discontinued LLVM Phabricator instance.

Differential D74194

[DebugInfo] Allow reading an address table with a mismatched address.
ClosedPublic

Authored by ikudrin on Feb 6 2020, 10:34 PM.

Details

Reviewers
probinson
dblaikie
aprantl
jhenderson
Commits
rG1ea99a2ebcb6: [DebugInfo] Allow reading an address table with a mismatched address.
Summary

This case does not look as an unrecoverable error.

Diff Detail

Event Timeline

ikudrin created this revision.Feb 6 2020, 10:34 PM
Herald added a subscriber: hiraditya. · View Herald TranscriptFeb 6 2020, 10:34 PM
ikudrin added a child revision: D74197: [DebugInfo] Simplify DWARFDebugAddr..Feb 6 2020, 10:49 PM
jhenderson accepted this revision.Feb 7 2020, 1:10 AM

LGTM.

This revision is now accepted and ready to land.Feb 7 2020, 1:10 AM
Closed by commit rG1ea99a2ebcb6: [DebugInfo] Allow reading an address table with a mismatched address. (authored by ikudrin). · Explain WhyFeb 8 2020, 5:02 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
DebugInfo/
DWARF/
10 lines
test/
tools/
llvm-dwarfdump/
X86/
12 lines

Diff 243079

llvm/lib/DebugInfo/DWARF/DWARFDebugAddr.cpp

Show First 20 Lines • Show All 102 Lines • ▼ Show 20 Lines return createStringError(errc::invalid_argument,
" by the DWARF unit header: %" PRIu16, " by the DWARF unit header: %" PRIu16,
HeaderOffset, HeaderData.Version, UnitVersion); HeaderOffset, HeaderData.Version, UnitVersion);
if (HeaderData.AddrSize != 4 && HeaderData.AddrSize != 8) if (HeaderData.AddrSize != 4 && HeaderData.AddrSize != 8)
return createStringError(errc::not_supported, return createStringError(errc::not_supported,
".debug_addr table at offset 0x%" PRIx64 ".debug_addr table at offset 0x%" PRIx64
" has unsupported address size %" PRIu8, " has unsupported address size %" PRIu8,
HeaderOffset, HeaderData.AddrSize); HeaderOffset, HeaderData.AddrSize);
if (HeaderData.AddrSize != AddrSize && AddrSize != 0) if (HeaderData.AddrSize != AddrSize && AddrSize != 0)
return createStringError(errc::invalid_argument, WarnCallback(createStringError(
".debug_addr table at offset 0x%" PRIx64 errc::invalid_argument,
" has address size %" PRIu8 ".debug_addr table at offset 0x%" PRIx64 " has address size %" PRIu8
" which is different from CU address size %" PRIu8, " which is different from CU address size %" PRIu8,
HeaderOffset, HeaderData.AddrSize, AddrSize); HeaderOffset, HeaderData.AddrSize, AddrSize));
// TODO: add support for non-zero segment selector size. // TODO: add support for non-zero segment selector size.
if (HeaderData.SegSize != 0) if (HeaderData.SegSize != 0)
return createStringError(errc::not_supported, return createStringError(errc::not_supported,
".debug_addr table at offset 0x%" PRIx64 ".debug_addr table at offset 0x%" PRIx64
" has unsupported segment selector size %" PRIu8, " has unsupported segment selector size %" PRIu8,
HeaderOffset, HeaderData.SegSize); HeaderOffset, HeaderData.SegSize);
if (DataSize % HeaderData.AddrSize != 0) { if (DataSize % HeaderData.AddrSize != 0) {
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines

llvm/test/tools/llvm-dwarfdump/X86/debug_addr_address_size_mismatch.s

# RUN: llvm-mc %s -filetype obj -triple i386-pc-linux -o - | \ # RUN: llvm-mc %s -filetype obj -triple i386-pc-linux -o - | \
# RUN: llvm-dwarfdump -debug-addr - 2> %t.err | FileCheck %s # RUN: llvm-dwarfdump -debug-addr - 2> %t.warn | FileCheck %s
# RUN: FileCheck %s -input-file %t.err -check-prefix=ERR # RUN: FileCheck %s -input-file %t.warn -check-prefix=WARN
# ERR: .debug_addr table at offset 0x0 has address size 8 which is different from CU address size 4 # WARN: .debug_addr table at offset 0x0 has address size 8 which is different from CU address size 4
# ERR-NOT: {{.}} # WARN-NOT: {{.}}
# CHECK: .debug_addr contents # CHECK: .debug_addr contents
# CHECK-NEXT: length = 0x0000000c, version = 0x0005, addr_size = 0x08, seg_size = 0x00
# CHECK-NEXT: Addrs: [
# CHECK-NEXT: 0x0000000100000000
# CHECK-NEXT: ]
# CHECK-NEXT: length = 0x0000000c, version = 0x0005, addr_size = 0x04, seg_size = 0x00 # CHECK-NEXT: length = 0x0000000c, version = 0x0005, addr_size = 0x04, seg_size = 0x00
# CHECK-NEXT: Addrs: [ # CHECK-NEXT: Addrs: [
# CHECK-NEXT: 0x00000000 # CHECK-NEXT: 0x00000000
# CHECK-NEXT: 0x00000001 # CHECK-NEXT: 0x00000001
# CHECK-NEXT: ] # CHECK-NEXT: ]
# CHECK-NOT: {{.}} # CHECK-NOT: {{.}}
.section .debug_abbrev,"",@progbits .section .debug_abbrev,"",@progbits
Show All 26 Lines