[DebugInfo] Use "an address table" in diagnostic messages of DWARFDebugAddr.
ClosedPublic
Actions

Authored by ikudrin on Feb 11 2020, 6:35 AM.

Details

Reviewers

dblaikie
jhenderson
probinson
aprantl

Commits

rG292b67f99310: [DebugInfo] Use "an address table" in diagnostic messages of DWARFDebugAddr.

Summary

This is an extract from D74196, according to @dblaikie's suggestion.

This replaces a collocation "a .debug_addr table" with "an address table" because the latter sounds more accurate.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

ikudrin created this revision.Feb 11 2020, 6:35 AM

Herald added a subscriber: hiraditya. · View Herald TranscriptFeb 11 2020, 6:35 AM

ikudrin mentioned this in D74196: [DebugInfo] Refine error messages in DWARFDebugAddr..Feb 11 2020, 6:39 AM

ikudrin added a child revision: D74196: [DebugInfo] Refine error messages in DWARFDebugAddr..Feb 11 2020, 6:42 AM

LGTM.

This revision is now accepted and ready to land.Feb 11 2020, 7:49 AM

Closed by commit rG292b67f99310: [DebugInfo] Use "an address table" in diagnostic messages of DWARFDebugAddr. (authored by ikudrin). · Explain WhyFeb 11 2020, 10:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

llvm/

lib/

DebugInfo/

DWARF/

DWARFDebugAddr.cpp

22 lines

test/

tools/

llvm-dwarfdump/

X86/

debug_addr_address_size_mismatch.s

2 lines

debug_addr_address_size_not_multiple.s

2 lines

debug_addr_segment_selector.s

2 lines

debug_addr_small_length_field.s

2 lines

debug_addr_too_small_for_length_field.s

2 lines

debug_addr_too_small_for_section.s

2 lines

debug_addr_version_mismatch.s

2 lines

Diff 244067

View Options

llvm/lib/DebugInfo/DWARF/DWARFDebugAddr.cpp

View Options

llvm/test/tools/llvm-dwarfdump/X86/debug_addr_address_size_mismatch.s

View Options

llvm/test/tools/llvm-dwarfdump/X86/debug_addr_address_size_not_multiple.s

View Options

llvm/test/tools/llvm-dwarfdump/X86/debug_addr_segment_selector.s

View Options

llvm/test/tools/llvm-dwarfdump/X86/debug_addr_small_length_field.s

View Options

llvm/test/tools/llvm-dwarfdump/X86/debug_addr_too_small_for_length_field.s

View Options

llvm/test/tools/llvm-dwarfdump/X86/debug_addr_too_small_for_section.s

View Options

llvm/test/tools/llvm-dwarfdump/X86/debug_addr_version_mismatch.s

[DebugInfo] Use "an address table" in diagnostic messages of DWARFDebugAddr.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 244067

llvm/lib/DebugInfo/DWARF/DWARFDebugAddr.cpp

llvm/test/tools/llvm-dwarfdump/X86/debug_addr_address_size_mismatch.s

llvm/test/tools/llvm-dwarfdump/X86/debug_addr_address_size_not_multiple.s

llvm/test/tools/llvm-dwarfdump/X86/debug_addr_segment_selector.s

llvm/test/tools/llvm-dwarfdump/X86/debug_addr_small_length_field.s

llvm/test/tools/llvm-dwarfdump/X86/debug_addr_too_small_for_length_field.s

llvm/test/tools/llvm-dwarfdump/X86/debug_addr_too_small_for_section.s

llvm/test/tools/llvm-dwarfdump/X86/debug_addr_version_mismatch.s

[DebugInfo] Use "an address table" in diagnostic messages of DWARFDebugAddr.
ClosedPublic
Actions

Revision Contents
Changeset List