Page MenuHomePhabricator

[AMDGPU] Cleanup assumptions about generated subregs
ClosedPublic

Authored by rampitec on Feb 6 2020, 3:45 PM.

Details

Summary

We are using countPopulation on a LaneBitmask to determine
a number of registers it covers. This is the assumption which
does not necessarily need to be true. It is not changed but
factored into a single call SIRegisterInfo::getNumCoveredRegs().

Some other places are cleaned up with respect to assumptions
about subreg indexes values and tablegen behavior.

Diff Detail

Event Timeline

rampitec created this revision.Feb 6 2020, 3:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2020, 3:45 PM
arsenm added inline comments.Feb 6 2020, 3:54 PM
llvm/lib/Target/AMDGPU/SIRegisterInfo.h
303

Typo Channeles

rampitec updated this revision to Diff 243040.Feb 6 2020, 4:13 PM
rampitec marked an inline comment as done.

Fixed typo.
Found 2 more places: SIAddIMGInit and computeIndirectRegAndOffset.

arsenm accepted this revision.Feb 6 2020, 5:05 PM
This revision is now accepted and ready to land.Feb 6 2020, 5:05 PM
This revision was automatically updated to reflect the committed changes.