This is an archive of the discontinued LLVM Phabricator instance.

Differential D74097

[mlir] Build fix for mlir-opt
ClosedPublic

Authored by kernhanda on Feb 5 2020, 3:41 PM.

Details

Reviewers
mehdi_amini
nicolasvasilache
ftynse
stephenneuendorffer
Commits
rG8dc3da7d58fe: [mlir] Build fix for mlir-opt
Summary

mlir-opt needs to link against MLIRLoopAnalysis

Diff Detail

Event Timeline

kernhanda created this revision.Feb 5 2020, 3:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2020, 3:41 PM
Herald added subscribers: llvm-commits, Joonsoo, liufengdb and 10 others. · View Herald Transcript
kernhanda edited the summary of this revision. (Show Details)Feb 5 2020, 3:42 PM
stephenneuendorffer accepted this revision.Feb 5 2020, 3:50 PM
stephenneuendorffer added a subscriber: stephenneuendorffer.

Yes...

This revision is now accepted and ready to land.Feb 5 2020, 3:50 PM
merge_guards_bot added a subscriber: merge_guards_bot.Feb 5 2020, 4:36 PM

Unit tests: pass. 62519 tests passed, 0 failed and 844 were skipped.

clang-tidy: pass.

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

Harbormaster failed remote builds in B45821: Diff 242772!Feb 5 2020, 4:38 PM
kernhanda updated this revision to Diff 242786.Feb 5 2020, 4:50 PM

formatting

Closed by commit rG8dc3da7d58fe: [mlir] Build fix for mlir-opt (authored by kernhanda, committed by • joker-eph-DISABLED). · Explain WhyFeb 5 2020, 9:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
mlir/
tools/
mlir-opt/
1 line

Diff 242772

mlir/tools/mlir-opt/CMakeLists.txt

Show All 13 Lines
add_llvm_library(MLIRMlirOptLib add_llvm_library(MLIRMlirOptLib
mlir-opt.cpp mlir-opt.cpp
) )
target_link_libraries(MLIRMlirOptLib target_link_libraries(MLIRMlirOptLib
${LIB_LIBS} ${LIB_LIBS}
) )
set(FULL_LINK_LIBS set(FULL_LINK_LIBS
MLIRAnalysis MLIRAnalysis
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

+  MLIRLoopAnalysis
Lint: Pre-merge checks: clang-format: please reformat the code ``` + MLIRLoopAnalysis ```
MLIRLoopAnalysis
MLIRAffineOps MLIRAffineOps
MLIRAffineToStandard MLIRAffineToStandard
MLIRDialect MLIRDialect
MLIRLoopsToGPU MLIRLoopsToGPU
MLIRLinalgToLLVM MLIRLinalgToLLVM
MLIRLoopToStandard MLIRLoopToStandard
MLIREDSC MLIREDSC
▲ Show 20 Lines • Show All 69 Lines • Show Last 20 Lines