[analyzer] Move fuchsia.Lock checker to alpha

[xazax.hun]

Summary

After experimenting with it a bit it looks like this is not quite ready yet for Fuchsia. Moving it to alpha until the problems are solved.

[NoQ]

You're the boss!

I guess you could add a list of problems to the checker header comment if you want others to join. Also you'll need to update release notes (D73966) :)

[xazax.hun]

In D74004#1858185, @NoQ wrote:

Also you'll need to update release notes (D73966) :)

I think this was merged after the release branch was created (https://github.com/llvm/llvm-project/blob/release/10.x/clang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp)

clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

 
 def Debug : Package<"debug">, Hidden;
 
 def CloneDetectionAlpha : Package<"clone">, ParentPackage<Alpha>;
 
 def NonDeterminismAlpha : Package<"nondeterminism">, ParentPackage<Alpha>;
 
 def Fuchsia : Package<"fuchsia">;
+def FuchsiaAlpha : Package<"fuchsia">, ParentPackage<Alpha>;
 
 //===----------------------------------------------------------------------===//
 // Core Checkers.
 //===----------------------------------------------------------------------===//
 
 let ParentPackage = Core in {
 
 def DereferenceChecker : Checker<"NullDereference">,

 //===----------------------------------------------------------------------===//
 
 let ParentPackage = Fuchsia in {
 
 def FuchsiaHandleChecker : Checker<"HandleChecker">,
   HelpText<"A Checker that detect leaks related to Fuchsia handles">,
   Documentation<HasDocumentation>;
 
+}
+
+let ParentPackage = FuchsiaAlpha in {
+
 def FuchsiaLockChecker : Checker<"Lock">,
   HelpText<"Check for the correct usage of locking APIs.">,
   Dependencies<[PthreadLockBase]>,
   Documentation<HasDocumentation>;
 
 } // end fuchsia
 

clang/lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp

 //===--- PthreadLockChecker.cpp - Check for locking problems ---*- C++ -*--===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // This file defines:
 //  * PthreadLockChecker, a simple lock -> unlock checker.
 //    Which also checks for XNU locks, which behave similarly enough to share
 //    code.
 //  * FuchsiaLocksChecker, which is also rather similar.
 //  * C11LockChecker which also closely follows Pthread semantics.
 //
+//  TODO: Path notes.
+//
 //===----------------------------------------------------------------------===//
 
 #include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
 #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
 #include "clang/StaticAnalyzer/Core/Checker.h"
 #include "clang/StaticAnalyzer/Core/CheckerManager.h"
 #include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
 #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"

clang/test/Analysis/fuchsia_lock.c

-// RUN: %clang_analyze_cc1 -analyzer-checker=fuchsia.Lock -verify %s
+// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.fuchsia.Lock -verify %s
 
 typedef int spin_lock_t;
 typedef int zx_status_t;
 typedef int zx_time_t;
 
 void spin_lock(spin_lock_t *lock);
 int spin_trylock(spin_lock_t *lock);
 void spin_unlock(spin_lock_t *lock);

clang/test/Analysis/fuchsia_lock_impl.c

-// RUN: %clang_analyze_cc1 -analyzer-checker=fuchsia.Lock -verify %s
+// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.fuchsia.Lock -verify %s
 // expected-no-diagnostics
 typedef int spin_lock_t;
 
 void spin_lock(spin_lock_t *lock);
 int getCond();
 int spin_trylock(spin_lock_t *lock) {
     if (getCond())
         return 0;