This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][asan][fuzzer][profile][ubsan] add lit multicfg test suite support
AcceptedPublic

Authored by ychen on Feb 4 2020, 10:52 AM.

Details

Reviewers
rnk
Group Reviewers
Restricted Project
Summary

llvm-lit /path/to/test/src should now invoke tests across all configurations. If this looks helpful, I could port other components.

For example

➜  bin/llvm-lit -vv ~/Src/u/compiler-rt/test/asan/TestCases/alloca_big_alignment.cpp
-- Testing: 4 tests, 4 workers --
PASS: AddressSanitizer-i386-linux-dynamic :: TestCases/alloca_big_alignment.cpp (1 of 4)
PASS: AddressSanitizer-x86_64-linux-dynamic :: TestCases/alloca_big_alignment.cpp (2 of 4)
PASS: AddressSanitizer-i386-linux :: TestCases/alloca_big_alignment.cpp (3 of 4)
PASS: AddressSanitizer-x86_64-linux :: TestCases/alloca_big_alignment.cpp (4 of 4)

Testing Time: 0.21s
  Expected Passes    : 4

Diff Detail

Event Timeline

ychen created this revision.Feb 4 2020, 10:52 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 4 2020, 10:52 AM
Herald added subscribers: llvm-commits, Restricted Project, mgorny, dberris. · View Herald Transcript

Unit tests: unknown.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

Thank you for this!
Please add UBsan, this has always been a pain point for me when doing sanitizer changes.

ychen added a comment.Feb 4 2020, 11:27 AM

Thank you for this!
Please add UBsan, this has always been a pain point for me when doing sanitizer changes.

:) Same here while working a little on Fuzzer. Will do.

ychen retitled this revision from [compiler-rt][asan][fuzzer][profile] switch to use lit multicfg test suite to [compiler-rt][asan][fuzzer][profile] add lit multicfg test suite support.Feb 4 2020, 11:38 AM
ychen added a reviewer: Restricted Project.Feb 5 2020, 9:13 PM
ychen updated this revision to Diff 243475.Feb 9 2020, 11:23 PM
ychen edited the summary of this revision. (Show Details)

add ubsan
move sub-suite adding part to be inside configure_lit_site_cfg

ychen retitled this revision from [compiler-rt][asan][fuzzer][profile] add lit multicfg test suite support to [compiler-rt][asan][fuzzer][profile][ubsan] add lit multicfg test suite support.Feb 9 2020, 11:24 PM
rnk accepted this revision.Feb 10 2020, 11:28 AM

lgtm, thanks!

This revision is now accepted and ready to land.Feb 10 2020, 11:28 AM
compiler-rt/test/ubsan_minimal/CMakeLists.txt