[CMake] Add missing component dependencies, to fix building for mingw with BUILD_SHARED_LIBS

[smeenai]

LGTM

[RKSimon]

@mstorsjo Ever since this commit there's an issue on some buildbots: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/62031

Any ideas?

FAIL: LLVM :: Feature/load_extension.ll (40496 of 56443)
******************** TEST 'LLVM :: Feature/load_extension.ll' FAILED ********************
Script:
--
: 'RUN: at line 1';   /home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/build/bin/opt /home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm-project/llvm/test/Feature/load_extension.ll -load=/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/build/./lib/Bye.so -goodbye -wave-goodbye -disable-output 2>&1 | /home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/build/bin/FileCheck /home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm-project/llvm/test/Feature/load_extension.ll
--
Exit Code: 1

Command Output (stderr):
--
/home/buildslave/ps4-buildslave4/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/llvm-project/llvm/test/Feature/load_extension.ll:3:10: error: CHECK: expected string not found in input
; CHECK: Bye
         ^
<stdin>:1:1: note: scanning from here
opt: CommandLine Error: Option 'enable-partial-inlining' registered more than once!
^
<stdin>:1:14: note: possible intended match here
opt: CommandLine Error: Option 'enable-partial-inlining' registered more than once!

[gkistanova]

Hello Martin,

I have reverted the remaining of this patch by f9219e644ac601ed00487bd6cb285503df5589dd.

llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast bot was red for a long time.
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/62414

Please let me know if you need any assistance with debugging on the llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast.

[mstorsjo]

In D73840#1862330, @RKSimon wrote:

@mstorsjo Ever since this commit there's an issue on some buildbots: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/62031

Any ideas?

In D73840#1871086, @gkistanova wrote:

Hello Martin,

I have reverted the remaining of this patch by f9219e644ac601ed00487bd6cb285503df5589dd.

llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast bot was red for a long time.
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/62414

Please let me know if you need any assistance with debugging on the llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast.

Sorry about this - I completely missed these mails back in February - sorry for leaving this broken, and thanks for fixing it.

I'll go ahead and commit a different kind of fix for this, the same as bc8e44218810c0db6328b9809c959ceb7d43e3f5, just disabling this for windows because this kind of setup, where symbols are expected to be located in the host loading the plugin, doesn't work there.

llvm/examples/Bye/CMakeLists.txt

 if(LLVM_BYE_LINK_INTO_TOOLS)
   message(WARNING "Setting LLVM_BYE_LINK_INTO_TOOLS=ON only makes sense for testing purpose")
 endif()
 
 add_llvm_pass_plugin(Bye
   Bye.cpp
   DEPENDS
   intrinsics_gen
   BUILDTREE_ONLY
+  LINK_COMPONENTS
+    ipo
+    Core
+    Support
  )
 
 install(TARGETS ${name} RUNTIME DESTINATION examples)
 set_target_properties(${name} PROPERTIES FOLDER "Examples")

llvm/tools/bugpoint-passes/CMakeLists.txt

 if( NOT LLVM_BUILD_TOOLS )
   set(EXCLUDE_FROM_ALL ON)
 endif()
 
 # If we don't need RTTI or EH, there's no reason to export anything
 # from this plugin.
 if( NOT LLVM_REQUIRES_RTTI )
   if( NOT LLVM_REQUIRES_EH )
     set(LLVM_EXPORTED_SYMBOL_FILE ${CMAKE_CURRENT_SOURCE_DIR}/bugpoint.exports)
   endif()
 endif()
 
 if(WIN32 OR CYGWIN)
-  set(LLVM_LINK_COMPONENTS Core)
+  set(LLVM_LINK_COMPONENTS Core Support)
 endif()
 
 add_llvm_library( BugpointPasses MODULE BUILDTREE_ONLY
   TestPasses.cpp
 
   DEPENDS
   intrinsics_gen
   bugpoint
   )

llvm/unittests/Passes/CMakeLists.txt

 # Needed by LLVM's CMake checks because this file defines multiple targets.
 set(LLVM_OPTIONAL_SOURCES PluginsTest.cpp TestPlugin.cpp)
 
 # If plugins are disabled, this test will disable itself at runtime. Otherwise,
 # reconfiguring with plugins disabled will leave behind a stale executable.
 if (LLVM_ENABLE_PLUGINS)
   add_definitions(-DLLVM_ENABLE_PLUGINS)
 endif()
 
 set(LLVM_LINK_COMPONENTS Support Passes Core)
 add_llvm_unittest(PluginsTests
   PluginsTest.cpp
   )
 export_executable_symbols(PluginsTests)
 target_link_libraries(PluginsTests PRIVATE LLVMTestingSupport)
 
-set(LLVM_LINK_COMPONENTS)
+set(LLVM_LINK_COMPONENTS Support Core)
 add_llvm_library(TestPlugin MODULE BUILDTREE_ONLY
   TestPlugin.cpp
   )
 
 # Put plugin next to the unit test executable.
 set_output_directory(TestPlugin
   BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}
   LIBRARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}
   )
 set_target_properties(TestPlugin PROPERTIES FOLDER "Tests")
 
 add_dependencies(TestPlugin intrinsics_gen)
 add_dependencies(PluginsTests TestPlugin)