Page MenuHomePhabricator

[CMake] Fix MSVC buggy version check
ClosedPublic

Authored by ctetreau on Jan 30 2020, 3:27 PM.

Details

Summary
  • Add parens and ${} to cmake check to work around CMake configure time "unknown arguments specified" issue

Event Timeline

ctetreau created this revision.Jan 30 2020, 3:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 30 2020, 3:27 PM
mehdi_amini accepted this revision.Jan 30 2020, 3:42 PM

Oh I missed this revision and reverted based on the comment in the original review (D73677).

I'm fine with your fix if it works, you will need to cherry-pick the original commit to land this on top.

This revision is now accepted and ready to land.Jan 30 2020, 3:42 PM

Thanks for the quick code review! I actually don't have commit access, can you please commit it for me? Thanks!

RKSimon closed this revision.Jan 31 2020, 3:54 AM
RKSimon added a subscriber: RKSimon.

This was committed at rG5f940220bf94