This is an archive of the discontinued LLVM Phabricator instance.

[mlir][ODS] Refactor BuildableType to use $_builder as part of the format
ClosedPublic

Authored by rriddle on Jan 30 2020, 12:12 PM.

Details

Summary

Currently BuildableType is assumed to be preceded by a builder. This prevents constructing types that don't have a callable 'get' method with the builder. This revision reworks the format to be like attribute builders, i.e. by accepting $_builder within the format itself.

Depends On D73735

Diff Detail

Event Timeline

rriddle created this revision.Jan 30 2020, 12:12 PM
antiagainst accepted this revision.Jan 30 2020, 12:14 PM
This revision is now accepted and ready to land.Jan 30 2020, 12:14 PM

Unit tests: fail. 62354 tests passed, 1 failed and 839 were skipped.

failed: libc++.std/containers/sequences/array/array_creation/to_array.fail.cpp

clang-tidy: pass.

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

This revision was automatically updated to reflect the committed changes.