Page MenuHomePhabricator

[analyzer] AnalyzerOptions: Remove 'fixits-as-remarks'
ClosedPublic

Authored by Charusso on Jan 30 2020, 10:35 AM.

Details

Summary

The new way of checking fix-its is %check_analyzer_fixit.

Diff Detail

Event Timeline

Charusso created this revision.Jan 30 2020, 10:35 AM
xazax.hun added a reviewer: Szelethus.EditedFeb 25 2020, 3:15 AM

Maybe Kristof has some opinion whether we still need this :) He might be up to date whether CodeChecker is using this feature.

NoQ accepted this revision.Feb 25 2020, 3:16 AM

Great, thanks!!

This revision is now accepted and ready to land.Feb 25 2020, 3:16 AM
NoQ added inline comments.Feb 25 2020, 3:23 AM
clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def
310

Maybe Kristof has some opinion whether we still need this :) He might be up to date whether CodeChecker is using this feature.

Well, it clearly said "for testing purposes" :P

It should be much easier for CodeChecker to read fixits from plists.

xazax.hun added inline comments.Feb 25 2020, 3:34 AM
clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def
310

Fair point :) LGTM!

xazax.hun accepted this revision.Feb 25 2020, 3:34 AM
Szelethus accepted this revision.Feb 25 2020, 4:44 AM

Looks great! Thanks!

[Achievement unlocked] 3 green marks.

Thanks!

This revision was automatically updated to reflect the committed changes.