The current code assumes that one always maps at least one loop to block
dimensions and at least one loop to thread dimensions. If either is not
the case, a loop would get mapped twice.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Good catch, thanks!
mlir/test/Conversion/LoopsToGPU/no_blocks_no_threads.mlir | ||
---|---|---|
11 | Nit: do we really need to know there are two "constant 1" emitted? |
Unit tests: pass. 62328 tests passed, 0 failed and 838 were skipped.
clang-tidy: pass.
clang-format: pass.
Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml
Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.
mlir/test/Conversion/LoopsToGPU/no_blocks_no_threads.mlir | ||
---|---|---|
11 | I took the NEXT from the other loop lowering test. The check for two constant 1 is there as we have two constants and I need to match the second. I want to make sure that unmapped grids/blocks actually are constant one. Is there a better way? |
mlir/test/Conversion/LoopsToGPU/no_blocks_no_threads.mlir | ||
---|---|---|
11 | I see. It's fine this way. |
Nit: do we really need to know there are two "constant 1" emitted?
More nit: does the absence of ops in between the given ops (-NEXT) matter?