Add IntegerAttr::verifyConstructionInvariants.

[silvas]

Summary

This will help catch improper use of the MLIR API's. In particular, this
catches an error that was manifesting as nondeterministic assertion
failures (the nondeterminism was due to the failure happening only when the
StorageUniquer's DenseMap's probing happened to compare two specific
keys).

No test. The fact that all the existing tests pass with this additional
invariant gives confidence that it is correct/useful.

[rriddle]

mlir/lib/IR/Attributes.cpp

294

nit: can you just return this directly?

308

nit: Can you add the widths as well to the message?

Note: emitOptionalError takes variadic arguments that are passed to the diagnostic

emitOptionalError(loc, "these are ", 3, " arguments to the diagnostic");

[merge_guards_bot]

Unit tests: pass. 62302 tests passed, 0 failed and 838 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

[silvas]

Fix review feeback.

[silvas]

Fix review feedback.

[merge_guards_bot]

Unit tests: pass. 62302 tests passed, 0 failed and 838 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

mlir/include/mlir/IR/Attributes.h

public:
   APInt getValue() const;
   // TODO(jpienaar): Change callers to use getValue instead.
   int64_t getInt() const;
 
   /// Methods for support type inquiry through isa, cast, and dyn_cast.
   static bool kindof(unsigned kind) {
     return kind == StandardAttributes::Integer;
   }
+
+  static LogicalResult verifyConstructionInvariants(Optional<Location> loc,
+                                                    MLIRContext *ctx, Type type,
+                                                    int64_t value);
+  static LogicalResult verifyConstructionInvariants(Optional<Location> loc,
+                                                    MLIRContext *ctx, Type type,
+                                                    const APInt &value);
 };
 
 //===----------------------------------------------------------------------===//
 // IntegerSetAttr
 //===----------------------------------------------------------------------===//
 
 class IntegerSetAttr
     : public Attribute::AttrBase<IntegerSetAttr, Attribute,

mlir/lib/IR/Attributes.cpp

IntegerAttr IntegerAttr::get(Type type, int64_t value) {
   auto intType = type.cast<IntegerType>();
   return get(type, APInt(intType.getWidth(), value));
 }
 
 APInt IntegerAttr::getValue() const { return getImpl()->getValue(); }
 
 int64_t IntegerAttr::getInt() const { return getValue().getSExtValue(); }
 
+static LogicalResult verifyIntegerTypeInvariants(Optional<Location> loc,
+                                                 Type type) {
+  if (type.isa<IntegerType>() || type.isa<IndexType>())
+    return success();
+  return emitOptionalError(loc, "expected integer or index type");
+}
+
+LogicalResult verifyConstructionInvariants(Optional<Location> loc,
+                                           MLIRContext *ctx, Type type,
+                                           int64_t value) {
+  if (failed(verifyIntegerTypeInvariants(loc, type)))
+    return failure();
+  return success();
+}
+
+LogicalResult IntegerAttr::verifyConstructionInvariants(Optional<Location> loc,
+                                                        MLIRContext *ctx,
+                                                        Type type,
+                                                        const APInt &value) {
+  if (failed(verifyIntegerTypeInvariants(loc, type)))
+    return failure();
+  if (auto integerType = type.dyn_cast<IntegerType>())
+    if (integerType.getWidth() != value.getBitWidth())
+      return emitOptionalError(
+          loc, "integer type bit width doesn't match value bit width");
+  return success();
+}
+
 //===----------------------------------------------------------------------===//
 // IntegerSetAttr
 //===----------------------------------------------------------------------===//
 
 IntegerSetAttr IntegerSetAttr::get(IntegerSet value) {
   return Base::get(value.getConstraint(0).getContext(),
                    StandardAttributes::IntegerSet, value);
 }