Page MenuHomePhabricator

[DebugInfo] Fix dumping CIE ID in .eh_frame sections.
ClosedPublic

Authored by ikudrin on Jan 29 2020, 6:58 AM.

Details

Summary

We do not keep the actual value of the CIE_id field, because it is predefined, and use a constant when dumping a CIE record. The issue was that the predefined value is different for .debug_frame and .eh_frame sections, but we always printed the same. The patch fixes that by choosing an appropriate constant to print.

Diff Detail

Event Timeline

ikudrin created this revision.Jan 29 2020, 6:58 AM

Can you point to a reference specifying this difference?

probinson accepted this revision.Feb 12 2020, 9:32 AM

IIUC, this patch expresses the difference between (32-bit) .debug_frame and .eh_frame, while D73887 takes care of the 64-bit case.
As long as the commit message has the link to the .eh_frame spec (which I think is harder to find than the DWARF spec), LGTM.

This revision is now accepted and ready to land.Feb 12 2020, 9:32 AM
This revision was automatically updated to reflect the committed changes.