This is an archive of the discontinued LLVM Phabricator instance.

[scudo][standalone] Fix Android logging
ClosedPublic

Authored by cryptoad on Jan 28 2020, 9:39 AM.

Details

Summary

Zygote & children's stderr is lost, so use Bionic's provided allocation
free syslog function for outputRaw. Get rid of the mutex as it's not
vital and could cause issues with fork.

Diff Detail

Event Timeline

cryptoad created this revision.Jan 28 2020, 9:39 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 28 2020, 9:39 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Unit tests: fail. 62268 tests passed, 3 failed and 827 were skipped.

failed: Clang.CodeGenOpenCL/amdgpu-features.cl
failed: Clang.CodeGenOpenCL/builtins-amdgcn-mfma.cl
failed: Clang.SemaOpenCL/builtins-amdgcn-error-gfx908-param.cl

clang-tidy: fail. clang-tidy found 0 errors and 4 warnings. 0 of them are added as review comments below (why?).

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.

hctim accepted this revision.Jan 28 2020, 10:29 AM
hctim added inline comments.
compiler-rt/lib/scudo/standalone/linux.cpp
173

nit: constexpr

This revision is now accepted and ready to land.Jan 28 2020, 10:29 AM
cryptoad updated this revision to Diff 240935.Jan 28 2020, 10:34 AM
cryptoad marked an inline comment as done.

constexpr-ing.

This revision was automatically updated to reflect the committed changes.

Unit tests: fail. 62268 tests passed, 3 failed and 827 were skipped.

failed: Clang.CodeGenOpenCL/amdgpu-features.cl
failed: Clang.CodeGenOpenCL/builtins-amdgcn-mfma.cl
failed: Clang.SemaOpenCL/builtins-amdgcn-error-gfx908-param.cl

clang-tidy: fail. clang-tidy found 0 errors and 4 warnings. 0 of them are added as review comments below (why?).

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.