User Details
- User Since
- Aug 6 2019, 3:45 PM (215 w, 6 d)
Wed, Sep 20
Tue, Sep 12
Mon, Sep 11
Tue, Sep 5
Thanks for catching this.
Wed, Aug 30
Tue, Aug 29
Actually remove rss files.
Looks good to me, but it's good to wait for Hans to take one last look.
Mon, Aug 28
Just a few comment nits.
LGTM
Aug 25 2023
Aug 23 2023
LGTM.
LGTM.
That sounds like a good plan.
Aug 21 2023
One small suggested change.
LGTM
Aug 18 2023
LGTM.
Aug 17 2023
One minor comment suggestion.
I modified the change and added an include because without unistd.h, PAGE_SIZE is not defined in many cases.
Added include of unistd.h and modified the return given comments.
Aug 16 2023
I followed enh's suggestion in https://reviews.llvm.org/D158123.
Sorry, I've been trying multiple ways of incorporating the value into the config and none of them work easily. They require changes to just about every file in the tree. I have a back up but that simply uses a #define instead of specialized on SCUDO_ANDROID. I think that might be the best way to go since it's not easy to use a config variable for this particular call.
Aug 15 2023
Aug 4 2023
Yeah, I should have checked for a divide by zero. Unfortunately, on arm that doesn't actually crash.
LGTM, but as with the other, good to wait for Chia-hung to take a look.
LGTM, but give Chia-hung a chance to comment too.
A minor comment nit.
Small question.
LGTM the new comments answered my questions.
Aug 3 2023
A few questions.
Aug 2 2023
LGTM.
LGTM.
Mostly comment nits.
Jul 31 2023
LGTM.
Small comment nit.
LGTM.
Jul 28 2023
LGTM as long as I am correct about the one comment I left.
LGTM.
Jul 26 2023
Yeah, I was thinking about this and it doesn't do much. However, I do think the const is useful just to make sure the compiler catches any places where we try to modify the value. And even though making it a reference doesn't really do anything, it also prevents people from coming along and asking why a structure is being passed on the stack.
Actually do a clang-format.
Remove the const Options &Options = Options.load();
Jul 25 2023
LGTM.
Jul 24 2023
LGTM.
LGTM.
Jul 21 2023
LGTM again.
Can you run clang format on this? By looking deep into the logs, I did see an error about clang format failing.
Jul 20 2023
LGTM. After the builds pass, I can submit this for you.
Jul 19 2023
clang format.
Jul 18 2023
Jul 17 2023
Jul 11 2023
LGTM
Make sense to me.
Small nit.
Jul 10 2023
LGTM
LGTM
Jun 29 2023
LGTM.
LGTM.
LGTM.
LGTM, but you misspelled concern in your commit message.
LGTM.