Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

cferris (Christopher Ferris)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 6 2019, 3:45 PM (215 w, 6 d)

Recent Activity

Wed, Sep 20

cferris requested changes to D159392: [scudo] Split the code path of memory tagging out from allocate().
Wed, Sep 20, 6:20 PM · Restricted Project, Restricted Project
cferris requested changes to D159396: [scudo] Split the code paths in quarantineOrDeallocateChunk().
Wed, Sep 20, 5:45 PM · Restricted Project, Restricted Project

Tue, Sep 12

cferris committed rG8feeba643d25: [scudo] Allow using a different test main. (authored by cferris).
[scudo] Allow using a different test main.
Tue, Sep 12, 11:03 AM · Restricted Project, Restricted Project
cferris closed D159501: [scudo] Allow using a different test main..
Tue, Sep 12, 11:03 AM · Restricted Project, Restricted Project

Mon, Sep 11

cferris requested review of D159501: [scudo] Allow using a different test main..
Mon, Sep 11, 4:52 PM · Restricted Project, Restricted Project

Tue, Sep 5

cferris accepted D159389: [scudo] Clean up decl of RSSLimit funtions (NFC).

Thanks for catching this.

Tue, Sep 5, 11:34 AM · Restricted Project, Restricted Project

Wed, Aug 30

cferris committed rGc8bf93dba0a2: [scudo] Remove RSS checking code. (authored by cferris).
[scudo] Remove RSS checking code.
Wed, Aug 30, 12:35 PM · Restricted Project, Restricted Project
cferris closed D159155: [scudo] Remove RSS checking code..
Wed, Aug 30, 12:35 PM · Restricted Project, Restricted Project

Tue, Aug 29

cferris updated the diff for D159155: [scudo] Remove RSS checking code..

Actually remove rss files.

Tue, Aug 29, 7:43 PM · Restricted Project, Restricted Project
cferris requested review of D159155: [scudo] Remove RSS checking code..
Tue, Aug 29, 7:40 PM · Restricted Project, Restricted Project
cferris accepted D156146: [scudo] Add ConditionVariable in SizeClassAllocator64.

Looks good to me, but it's good to wait for Hans to take one last look.

Tue, Aug 29, 7:26 PM · Restricted Project, Restricted Project

Mon, Aug 28

cferris added a comment to D156146: [scudo] Add ConditionVariable in SizeClassAllocator64.

Just a few comment nits.

Mon, Aug 28, 3:04 PM · Restricted Project, Restricted Project
cferris accepted D158784: [scudo] Add SCUDO_ENABLE_HOOKS to enable hooks at compilation time.

LGTM

Mon, Aug 28, 2:30 PM · Restricted Project, Restricted Project
cferris added inline comments to D158784: [scudo] Add SCUDO_ENABLE_HOOKS to enable hooks at compilation time.
Mon, Aug 28, 2:03 PM · Restricted Project, Restricted Project
cferris requested changes to D158784: [scudo] Add SCUDO_ENABLE_HOOKS to enable hooks at compilation time.
Mon, Aug 28, 12:34 PM · Restricted Project, Restricted Project

Aug 25 2023

cferris requested changes to D158784: [scudo] Add SCUDO_ENABLE_HOOKS to enable hooks at compilation time.
Aug 25 2023, 3:19 PM · Restricted Project, Restricted Project

Aug 23 2023

cferris accepted D158456: [scudo] Move the decision making of page release to hasChanceToReleasePages().

LGTM.

Aug 23 2023, 7:42 PM · Restricted Project, Restricted Project
cferris accepted D158455: [scudo] Move the blocks marking logic into markFreeBlocks().

LGTM.

Aug 23 2023, 7:41 PM · Restricted Project, Restricted Project
cferris accepted D152188: [scudo] Detach the hooks from Scudo's internal implementation.

That sounds like a good plan.

Aug 23 2023, 7:40 PM · Restricted Project, Restricted Project

Aug 21 2023

cferris requested changes to D158456: [scudo] Move the decision making of page release to hasChanceToReleasePages().

One small suggested change.

Aug 21 2023, 6:57 PM · Restricted Project, Restricted Project
cferris requested changes to D158455: [scudo] Move the blocks marking logic into markFreeBlocks().
Aug 21 2023, 6:47 PM · Restricted Project, Restricted Project
cferris accepted D158454: [scudo] Support dumping fragmentation data in SizeClassAllocator32.

LGTM

Aug 21 2023, 6:36 PM · Restricted Project, Restricted Project
cferris committed rG41a275321fdf: [scudo] Fix definition of SCUDO_SMALL_STACK_DEPOT. (authored by cferris).
[scudo] Fix definition of SCUDO_SMALL_STACK_DEPOT.
Aug 21 2023, 3:18 PM · Restricted Project, Restricted Project
cferris closed D158459: [scudo] Fix definition of SCUDO_SMALL_STACK_DEPOT..
Aug 21 2023, 3:18 PM · Restricted Project, Restricted Project
cferris added a reviewer for D158459: [scudo] Fix definition of SCUDO_SMALL_STACK_DEPOT.: ahomescu.
Aug 21 2023, 2:54 PM · Restricted Project, Restricted Project
cferris requested review of D158459: [scudo] Fix definition of SCUDO_SMALL_STACK_DEPOT..
Aug 21 2023, 2:52 PM · Restricted Project, Restricted Project

Aug 18 2023

cferris accepted D158225: [scudo] Support dumping fragmentation data in SizeClassAllocator64.

LGTM.

Aug 18 2023, 12:53 PM · Restricted Project, Restricted Project

Aug 17 2023

cferris committed rGd36180e6e2c0: [scudo] Fix typo. (authored by cferris).
[scudo] Fix typo.
Aug 17 2023, 7:27 PM · Restricted Project, Restricted Project
cferris closed D158240: [scudo] Fix typo..
Aug 17 2023, 7:26 PM · Restricted Project, Restricted Project
cferris requested review of D158240: [scudo] Fix typo..
Aug 17 2023, 6:56 PM · Restricted Project, Restricted Project
cferris added a comment to D158225: [scudo] Support dumping fragmentation data in SizeClassAllocator64.

One minor comment suggestion.

Aug 17 2023, 6:48 PM · Restricted Project, Restricted Project
cferris committed rG96081768daac: [scudo] Modify hard-coded page size for Android. (authored by cferris).
[scudo] Modify hard-coded page size for Android.
Aug 17 2023, 6:18 PM · Restricted Project, Restricted Project
cferris closed D158123: [scudo] Modify hard-coded page size for Android..
Aug 17 2023, 6:18 PM · Restricted Project, Restricted Project
cferris added inline comments to D158123: [scudo] Modify hard-coded page size for Android..
Aug 17 2023, 4:11 PM · Restricted Project, Restricted Project
cferris added a comment to D158123: [scudo] Modify hard-coded page size for Android..

I modified the change and added an include because without unistd.h, PAGE_SIZE is not defined in many cases.

Aug 17 2023, 4:10 PM · Restricted Project, Restricted Project
cferris updated the diff for D158123: [scudo] Modify hard-coded page size for Android..

Added include of unistd.h and modified the return given comments.

Aug 17 2023, 4:09 PM · Restricted Project, Restricted Project

Aug 16 2023

cferris added a comment to D151585: Remove hardcoded page size when compiling on android.

I followed enh's suggestion in https://reviews.llvm.org/D158123.

Aug 16 2023, 2:56 PM · Restricted Project, Restricted Project
cferris requested review of D158123: [scudo] Modify hard-coded page size for Android..
Aug 16 2023, 2:55 PM · Restricted Project, Restricted Project
cferris added a comment to D151585: Remove hardcoded page size when compiling on android.

Sorry, I've been trying multiple ways of incorporating the value into the config and none of them work easily. They require changes to just about every file in the tree. I have a back up but that simply uses a #define instead of specialized on SCUDO_ANDROID. I think that might be the best way to go since it's not easy to use a config variable for this particular call.

Aug 16 2023, 2:02 PM · Restricted Project, Restricted Project

Aug 15 2023

cferris committed rGef82a53bbb89: [scudo] Change Classes definition to uptr. (authored by cferris).
[scudo] Change Classes definition to uptr.
Aug 15 2023, 9:12 PM · Restricted Project, Restricted Project
cferris closed D158048: [scudo] Change Classes definition to uptr..
Aug 15 2023, 9:12 PM · Restricted Project, Restricted Project
cferris requested review of D158048: [scudo] Change Classes definition to uptr..
Aug 15 2023, 8:40 PM · Restricted Project, Restricted Project

Aug 4 2023

cferris accepted D157154: [scudo] Dump MapAllocatorCache::retrieve() data.

Yeah, I should have checked for a divide by zero. Unfortunately, on arm that doesn't actually crash.

Aug 4 2023, 7:02 PM · Restricted Project, Restricted Project
cferris accepted D157155: [scudo] secondary allocator cache optimal-fit retrieval.

LGTM, but as with the other, good to wait for Chia-hung to take a look.

Aug 4 2023, 5:36 PM · Restricted Project, Restricted Project
cferris accepted D157154: [scudo] Dump MapAllocatorCache::retrieve() data.

LGTM, but give Chia-hung a chance to comment too.

Aug 4 2023, 4:54 PM · Restricted Project, Restricted Project
cferris requested changes to D157155: [scudo] secondary allocator cache optimal-fit retrieval.

A minor comment nit.

Aug 4 2023, 4:49 PM · Restricted Project, Restricted Project
cferris requested changes to D157154: [scudo] Dump MapAllocatorCache::retrieve() data.

Small question.

Aug 4 2023, 4:39 PM · Restricted Project, Restricted Project
cferris accepted D146453: [scudo] Implement and enable MemMapLinux.

LGTM the new comments answered my questions.

Aug 4 2023, 4:37 PM · Restricted Project, Restricted Project

Aug 3 2023

cferris requested changes to D146453: [scudo] Implement and enable MemMapLinux.

A few questions.

Aug 3 2023, 7:02 PM · Restricted Project, Restricted Project

Aug 2 2023

cferris accepted D156951: [scudo] Fine tune busy-waiting in HybridMutex.

LGTM.

Aug 2 2023, 6:14 PM · Restricted Project, Restricted Project
cferris accepted D156952: [scudo] Specify memory order while using atomic_compare_exchange.

LGTM.

Aug 2 2023, 5:13 PM · Restricted Project, Restricted Project
cferris requested changes to D156951: [scudo] Fine tune busy-waiting in HybridMutex.

Mostly comment nits.

Aug 2 2023, 5:13 PM · Restricted Project, Restricted Project

Jul 31 2023

cferris accepted D156740: [scudo] Skip visiting all free blocks if grouping is disabled.

LGTM.

Jul 31 2023, 2:12 PM · Restricted Project, Restricted Project
cferris added a comment to D156740: [scudo] Skip visiting all free blocks if grouping is disabled.

Small comment nit.

Jul 31 2023, 2:07 PM · Restricted Project, Restricted Project
cferris added a comment to D156582: [scudo] CanCache should use Size + HeadersSize instead of RoundedSize.

LGTM.

Jul 31 2023, 1:06 PM · Restricted Project, Restricted Project

Jul 28 2023

cferris accepted D156582: [scudo] CanCache should use Size + HeadersSize instead of RoundedSize.

LGTM as long as I am correct about the one comment I left.

Jul 28 2023, 8:42 PM · Restricted Project, Restricted Project
cferris accepted D156586: [scudo] Respect the return value of ReservedMemory::create() (NFC).

LGTM.

Jul 28 2023, 8:30 PM · Restricted Project, Restricted Project

Jul 26 2023

cferris committed rG867f2d9e5c9a: [scudo] Make Options a reference for functions. (authored by cferris).
[scudo] Make Options a reference for functions.
Jul 26 2023, 6:22 PM · Restricted Project, Restricted Project
cferris closed D156372: [scudo] Make Options a reference for functions..
Jul 26 2023, 6:22 PM · Restricted Project, Restricted Project
cferris added a comment to D156372: [scudo] Make Options a reference for functions..

Yeah, I was thinking about this and it doesn't do much. However, I do think the const is useful just to make sure the compiler catches any places where we try to modify the value. And even though making it a reference doesn't really do anything, it also prevents people from coming along and asking why a structure is being passed on the stack.

Jul 26 2023, 4:51 PM · Restricted Project, Restricted Project
cferris updated the summary of D156372: [scudo] Make Options a reference for functions..
Jul 26 2023, 4:51 PM · Restricted Project, Restricted Project
cferris updated the diff for D156372: [scudo] Make Options a reference for functions..

Actually do a clang-format.

Jul 26 2023, 2:42 PM · Restricted Project, Restricted Project
cferris updated the diff for D156372: [scudo] Make Options a reference for functions..

Remove the const Options &Options = Options.load();

Jul 26 2023, 2:40 PM · Restricted Project, Restricted Project
cferris requested review of D156372: [scudo] Make Options a reference for functions..
Jul 26 2023, 2:32 PM · Restricted Project, Restricted Project

Jul 25 2023

cferris accepted D156147: [scudo] Acquire FLLock in mergeGroupsToReleaseBack.

LGTM.

Jul 25 2023, 12:45 PM · Restricted Project, Restricted Project

Jul 24 2023

cferris added inline comments to D156147: [scudo] Acquire FLLock in mergeGroupsToReleaseBack.
Jul 24 2023, 3:07 PM · Restricted Project, Restricted Project
cferris accepted D156148: [scudo] Remove dead code in pushBlocksImpl (NFC).

LGTM.

Jul 24 2023, 1:24 PM · Restricted Project, Restricted Project
cferris accepted D155983: [scudo] set/check invalid cache entries.

LGTM.

Jul 24 2023, 1:22 PM · Restricted Project, Restricted Project

Jul 21 2023

cferris added inline comments to D155983: [scudo] set/check invalid cache entries.
Jul 21 2023, 4:39 PM · Restricted Project, Restricted Project
cferris accepted D155660: [scudo] seperate cache retrieval logic.

LGTM again.

Jul 21 2023, 4:35 PM · Restricted Project, Restricted Project
cferris requested changes to D155660: [scudo] seperate cache retrieval logic.

Can you run clang format on this? By looking deep into the logs, I did see an error about clang format failing.

Jul 21 2023, 3:57 PM · Restricted Project, Restricted Project

Jul 20 2023

cferris accepted D155660: [scudo] seperate cache retrieval logic.

LGTM. After the builds pass, I can submit this for you.

Jul 20 2023, 2:24 PM · Restricted Project, Restricted Project
cferris committed rGaf41f79f40f4: [scudo] Clean up tests. (authored by cferris).
[scudo] Clean up tests.
Jul 20 2023, 2:03 PM · Restricted Project, Restricted Project
cferris closed D155749: [scudo] Clean up tests..
Jul 20 2023, 2:03 PM · Restricted Project, Restricted Project
cferris added inline comments to D155749: [scudo] Clean up tests..
Jul 20 2023, 2:00 PM · Restricted Project, Restricted Project
cferris added inline comments to D155660: [scudo] seperate cache retrieval logic.
Jul 20 2023, 11:29 AM · Restricted Project, Restricted Project

Jul 19 2023

cferris requested changes to D155660: [scudo] seperate cache retrieval logic.
Jul 19 2023, 4:51 PM · Restricted Project, Restricted Project
cferris updated the diff for D155749: [scudo] Clean up tests..

clang format.

Jul 19 2023, 1:46 PM · Restricted Project, Restricted Project
cferris requested review of D155749: [scudo] Clean up tests..
Jul 19 2023, 1:46 PM · Restricted Project, Restricted Project

Jul 18 2023

cferris committed rG902c41fc8002: [scudo] Fix memtag tests. (authored by cferris).
[scudo] Fix memtag tests.
Jul 18 2023, 1:52 PM · Restricted Project, Restricted Project
cferris closed D155538: [scudo] Fix memtag tests..
Jul 18 2023, 1:52 PM · Restricted Project, Restricted Project

Jul 17 2023

cferris requested review of D155538: [scudo] Fix memtag tests..
Jul 17 2023, 7:42 PM · Restricted Project, Restricted Project

Jul 11 2023

cferris accepted D155015: Reland "[scudo] Support partial concurrent page release in SizeClassAllocator64".

LGTM

Jul 11 2023, 7:04 PM · Restricted Project, Restricted Project
cferris accepted D155009: Revert "[scudo] Support partial concurrent page release in SizeClassAllocator64".

Make sense to me.

Jul 11 2023, 1:32 PM · Restricted Project, Restricted Project
cferris requested changes to D155009: Revert "[scudo] Support partial concurrent page release in SizeClassAllocator64".

Small nit.

Jul 11 2023, 1:21 PM · Restricted Project, Restricted Project

Jul 10 2023

cferris accepted D154894: [scudo] Simple coding style fix in mem_map_base.h (NFC).

LGTM

Jul 10 2023, 2:27 PM · Restricted Project, Restricted Project
cferris accepted D154551: [scudo] Print PushedBytesDelta in getStats().

LGTM

Jul 10 2023, 2:26 PM · Restricted Project, Restricted Project

Jun 29 2023

cferris accepted D153608: [scudo] Support partial concurrent page release in SizeClassAllocator64.

LGTM.

Jun 29 2023, 3:26 PM · Restricted Project, Restricted Project
cferris accepted D153492: [scudo] Allow pushing single block to the freelist of BatchClass.

LGTM.

Jun 29 2023, 3:24 PM · Restricted Project, Restricted Project
cferris accepted D152596: [scudo] Extract steps releaseToOSMaybe into functions in.

LGTM.

Jun 29 2023, 3:22 PM · Restricted Project, Restricted Project
cferris accepted D154148: [scudo] Improve Secondary Cache Dump.

LGTM, but you misspelled concern in your commit message.

Jun 29 2023, 3:10 PM · Restricted Project, Restricted Project
cferris accepted D154041: [scudo] Restore Freelist when we fail on PageMap creation.

LGTM.

Jun 29 2023, 2:01 PM · Restricted Project, Restricted Project
cferris requested changes to D154148: [scudo] Improve Secondary Cache Dump.
Jun 29 2023, 1:41 PM · Restricted Project, Restricted Project
cferris committed rG36ca9a29025a: [scudo] Use getMonotonicTimeFast for tryLock. (authored by cferris).
[scudo] Use getMonotonicTimeFast for tryLock.
Jun 29 2023, 1:07 PM · Restricted Project, Restricted Project
cferris closed D154039: [scudo] Use getMonotonicTimeFast for tryLock..
Jun 29 2023, 1:07 PM · Restricted Project, Restricted Project

Jun 28 2023

cferris requested review of D154039: [scudo] Use getMonotonicTimeFast for tryLock..
Jun 28 2023, 7:50 PM · Restricted Project, Restricted Project
cferris requested changes to D153492: [scudo] Allow pushing single block to the freelist of BatchClass.
Jun 28 2023, 7:34 PM · Restricted Project, Restricted Project
cferris requested changes to D153608: [scudo] Support partial concurrent page release in SizeClassAllocator64.
Jun 28 2023, 7:00 PM · Restricted Project, Restricted Project
cferris requested changes to D152596: [scudo] Extract steps releaseToOSMaybe into functions in.
Jun 28 2023, 6:35 PM · Restricted Project, Restricted Project
cferris committed rGbd694683eb2c: [scudo] Use fast get time in secondary. (authored by cferris).
[scudo] Use fast get time in secondary.
Jun 28 2023, 5:30 PM · Restricted Project, Restricted Project