Page MenuHomePhabricator

cferris (Christopher Ferris)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 6 2019, 3:45 PM (34 w, 4 d)

Recent Activity

Thu, Mar 19

cferris accepted D76430: [scudo][standalone] Allow fallback to secondary if primary is full.

This passes all tests in the Android environment.

Thu, Mar 19, 2:49 PM · Restricted Project

Mar 4 2020

cferris accepted D75551: [scudo][standalone] Do not fill 32b regions at once.

The performance after this change is slightly worse for 32 bit, but not by much. and a lot of time seems to be within the variance However, it dramatically reduces the RSS for dex2oat, where it's much closer to jemalloc. It also reduces some of the traces RSS, but not by a large margin.

Mar 4 2020, 9:32 AM · Restricted Project, Restricted Project

Feb 26 2020

cferris accepted D75142: [scudo][standalone] Various improvements wrt RSS.

The performance is about the same as previous and it does shave about 1MB to 2MB of RSS in many cases. It also decrease the camera process by about 2MB.

Feb 26 2020, 10:13 AM · Restricted Project, Restricted Project

Feb 25 2020

cferris added inline comments to D75142: [scudo][standalone] Various improvements wrt RSS.
Feb 25 2020, 11:38 PM · Restricted Project, Restricted Project

Feb 14 2020

cferris added inline comments to D74448: [scudo][standalone] Allow setting release to OS.
Feb 14 2020, 10:57 AM · Restricted Project, Restricted Project
cferris updated the diff for D74448: [scudo][standalone] Allow setting release to OS.

Update the mallopt and remove the ability to set the
primary and secondary differently.

Feb 14 2020, 10:49 AM · Restricted Project, Restricted Project
cferris updated the diff for D74448: [scudo][standalone] Allow setting release to OS.

Add static_casts where needed.

Feb 14 2020, 10:48 AM · Restricted Project, Restricted Project
cferris updated the diff for D74448: [scudo][standalone] Allow setting release to OS.

Created a min and max release to OS value for the allocators.

Feb 14 2020, 7:46 AM · Restricted Project, Restricted Project

Feb 13 2020

cferris updated the diff for D74448: [scudo][standalone] Allow setting release to OS.
Feb 13 2020, 3:09 PM · Restricted Project, Restricted Project

Feb 11 2020

cferris added reviewers for D74448: [scudo][standalone] Allow setting release to OS: pcc, cryptoad.

I added a parameter to the primary and secondary, but I'm not sure when to set using the default. Right now, if the flag release_to_os_interval is set to -1, then it uses the default. I think that it would be better to have the default always override, but what do you think?

Feb 11 2020, 3:17 PM · Restricted Project, Restricted Project
cferris abandoned D74232: scudo: Add way to set release interval for both allocators..

Changed this enough, so I'm abandoning this.

Feb 11 2020, 3:08 PM · Restricted Project, Restricted Project
cferris created D74448: [scudo][standalone] Allow setting release to OS.
Feb 11 2020, 2:59 PM · Restricted Project, Restricted Project

Feb 10 2020

cferris accepted D74366: scudo: Fix Android build..

This fixes the build failure for me.

Feb 10 2020, 4:57 PM · Restricted Project, Restricted Project
cferris added a comment to D73824: scudo: Table driven size classes for Android allocator..

I do see RSS benefits in 32 bit, but the benefits are much larger in 64 bit runs. I see some performance fluctuations, but it looks like some got faster, some got slower, so probably in the noise.

Feb 10 2020, 9:32 AM · Restricted Project, Restricted Project

Feb 7 2020

cferris updated the diff for D74232: scudo: Add way to set release interval for both allocators..

Removed the minimum flags and create and Android specific mallopt setting.

Feb 7 2020, 9:58 AM · Restricted Project, Restricted Project
cferris updated the diff for D74232: scudo: Add way to set release interval for both allocators..

Updated mallopt for android.

Feb 7 2020, 9:40 AM · Restricted Project, Restricted Project
cferris created D74232: scudo: Add way to set release interval for both allocators..
Feb 7 2020, 9:40 AM · Restricted Project, Restricted Project

Dec 20 2019

cferris accepted D71772: [scudo][standalone] Support __BIONIC__.

LGTM

Dec 20 2019, 12:49 PM · Restricted Project, Restricted Project
cferris added a comment to D71772: [scudo][standalone] Support __BIONIC__.

I verified this fixes the case of building bionic on linux, and it also builds properly in the normal android build.

Dec 20 2019, 11:11 AM · Restricted Project, Restricted Project
cferris added inline comments to D71772: [scudo][standalone] Support __BIONIC__.
Dec 20 2019, 9:49 AM · Restricted Project, Restricted Project

Nov 8 2019

cferris created D70031: [scudo][standalone] Match function name change to bionic name change..
Nov 8 2019, 3:38 PM · Restricted Project, Restricted Project

Sep 9 2019

cferris abandoned D66123: [scudo][standalone] Clean-up of Android specific compilation..

This isn't quite right for the way people expect this to compile, so abandon this change.

Sep 9 2019, 1:00 PM · Restricted Project, Restricted Project

Aug 12 2019

cferris created D66123: [scudo][standalone] Clean-up of Android specific compilation..
Aug 12 2019, 5:17 PM · Restricted Project, Restricted Project