Page MenuHomePhabricator

[Clang] Enable -fsanitize=leak on Fuchsia targets
ClosedPublic

Authored by mcgrathr on Jan 24 2020, 5:56 PM.

Details

Summary

This required some fixes to the generic code for two issues:

  1. -fsanitize=safe-stack is default on x86_64-fuchsia and is *not* incompatible with -fsanitize=leak on Fuchisa
  1. -fsanitize=leak and other static-only runtimes must not be omitted under -shared-libsan (which is the default on Fuchsia)

Diff Detail

Event Timeline

mcgrathr created this revision.Jan 24 2020, 5:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2020, 5:56 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
mcgrathr updated this revision to Diff 240346.Jan 24 2020, 6:14 PM

Fixed Android SafeStack case, now passing check-clang.

phosek accepted this revision.Jan 24 2020, 8:45 PM

LGTM

This revision is now accepted and ready to land.Jan 24 2020, 8:45 PM
This revision was automatically updated to reflect the committed changes.