Page MenuHomePhabricator

aarongreen (Aaron Green)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 15 2017, 2:45 PM (187 w, 1 d)

Recent Activity

Thu, May 27

aarongreen updated the diff for D102447: Refactor mutation strategies into a standalone library.

The previous patch was a long-shot to try to get clang-tidy to find clang/clang.h. It didn't work, so there's no reason to modify tests/CMakeLists.txt. The patch reverts it.

Thu, May 27, 5:10 PM · Restricted Project
aarongreen updated the diff for D102447: Refactor mutation strategies into a standalone library.
Thu, May 27, 4:24 PM · Restricted Project
aarongreen updated the diff for D102447: Refactor mutation strategies into a standalone library.

Add no-sanitize-all to from* functions.

Thu, May 27, 1:32 PM · Restricted Project
aarongreen updated the diff for D102447: Refactor mutation strategies into a standalone library.
Thu, May 27, 12:02 PM · Restricted Project
aarongreen abandoned D103249: Reland: Refactor mutation strategies into a standalone library.

Original revision reopened instead.

Thu, May 27, 12:00 PM
aarongreen updated the diff for D102447: Refactor mutation strategies into a standalone library.

Fixed an issue with msan function pointers being uninitialized.

Thu, May 27, 11:59 AM · Restricted Project
aarongreen reopened D102447: Refactor mutation strategies into a standalone library.
Thu, May 27, 11:58 AM · Restricted Project
aarongreen updated the diff for D103249: Reland: Refactor mutation strategies into a standalone library.

Added some feature macros to detect msan and include msan_interface properly for the standalone build.

Thu, May 27, 11:57 AM
aarongreen added a comment to D103249: Reland: Refactor mutation strategies into a standalone library.

I have to hit pause on this. While the normal cmake approach passes, I just noticed the standalone approach to building the unit test doesn't.

Thu, May 27, 7:16 AM
aarongreen requested review of D103249: Reland: Refactor mutation strategies into a standalone library.
Thu, May 27, 7:13 AM

Tue, May 25

aarongreen updated the diff for D102447: Refactor mutation strategies into a standalone library.
Tue, May 25, 10:00 AM · Restricted Project
aarongreen added a comment to D102447: Refactor mutation strategies into a standalone library.

Please remove libMutagen.a from the diff before landing since we don't have libFuzzer.a in the current tree either.

Tue, May 25, 9:58 AM · Restricted Project

Mon, May 24

aarongreen updated the diff for D102447: Refactor mutation strategies into a standalone library.

3 out of the 4 lines clang-tidy complains about match what's in other source files on main; this change addresses the last one.

Mon, May 24, 7:14 AM · Restricted Project

Fri, May 21

aarongreen added inline comments to D102447: Refactor mutation strategies into a standalone library.
Fri, May 21, 2:53 PM · Restricted Project
aarongreen updated the diff for D102447: Refactor mutation strategies into a standalone library.
Fri, May 21, 2:53 PM · Restricted Project

May 18 2021

aarongreen accepted D96450: [libFuzzer] Use crash stack for fuchsia..
May 18 2021, 2:09 PM · Restricted Project

May 13 2021

aarongreen requested review of D102447: Refactor mutation strategies into a standalone library.
May 13 2021, 2:52 PM · Restricted Project

Apr 8 2021

aarongreen added inline comments to D96450: [libFuzzer] Use crash stack for fuchsia..
Apr 8 2021, 4:04 PM · Restricted Project

Mar 31 2021

aarongreen updated the diff for D94514: Support module-relative values in FuzzerMerge.
Mar 31 2021, 2:41 PM · Restricted Project
aarongreen updated the summary of D94510: Tweak SimpleFastHash.
Mar 31 2021, 11:40 AM · Restricted Project
aarongreen added a comment to D94510: Tweak SimpleFastHash.

See comments on D94512 and D94514. This revision no longer descends from D94508 or D94509 as we no longer need fuzzer::ModuleRelativeValues or the changes to FuzzerFork.cpp.

Mar 31 2021, 11:39 AM · Restricted Project
aarongreen updated the diff for D94512: Add ModuleInfo to TracePC.

Moved the ModuleInfo struct from FuzzerModuleRelative.h to FuzzerTracePC.h and added MoudleInfoByHash. Along with the decision in D94514 to not support relative features when -fork=1, this obviates the need for D94508 and D94509.

Mar 31 2021, 11:36 AM · Restricted Project
aarongreen added inline comments to D94514: Support module-relative values in FuzzerMerge.
Mar 31 2021, 11:29 AM · Restricted Project
aarongreen updated the diff for D94514: Support module-relative values in FuzzerMerge.
Mar 31 2021, 11:29 AM · Restricted Project

Mar 30 2021

aarongreen added a comment to D94514: Support module-relative values in FuzzerMerge.

Fine with me if it reduces performance issues.

Mar 30 2021, 5:54 PM · Restricted Project
aarongreen updated the diff for D94514: Support module-relative values in FuzzerMerge.
Mar 30 2021, 5:43 PM · Restricted Project

Mar 29 2021

aarongreen added a comment to D94514: Support module-relative values in FuzzerMerge.

I'm playing a bit with a version that introduces new markers: "FT_REL" and "COV_REL". I'll finish that up soon, post it, and collect some more perf numbers.

Mar 29 2021, 4:16 PM · Restricted Project

Mar 22 2021

aarongreen added inline comments to D94521: Add FuzzerRemote.
Mar 22 2021, 4:09 PM · Restricted Project
aarongreen updated the diff for D94521: Add FuzzerRemote.
Mar 22 2021, 4:06 PM · Restricted Project
aarongreen added a comment to D94521: Add FuzzerRemote.

Crud... I just noticed the .o files. New diff incoming...

Mar 22 2021, 4:03 PM · Restricted Project
aarongreen added inline comments to D94521: Add FuzzerRemote.
Mar 22 2021, 4:03 PM · Restricted Project
aarongreen updated the diff for D94521: Add FuzzerRemote.
Mar 22 2021, 4:03 PM · Restricted Project
aarongreen updated the diff for D96089: Move deprecated sancov functions to separate file..
Mar 22 2021, 3:53 PM · Restricted Project
aarongreen updated the diff for D94519: Add thread annotations..
Mar 22 2021, 3:52 PM · Restricted Project
aarongreen updated the diff for D94518: Move MallocFreeTracer to FuzzerMonitor.
Mar 22 2021, 3:52 PM · Restricted Project
aarongreen updated the diff for D94517: Extract and expose FuzzerMonitor C interface..
Mar 22 2021, 3:51 PM · Restricted Project
aarongreen updated the diff for D94514: Support module-relative values in FuzzerMerge.

Regarding performance: I added some microbenchmarks in Merger::Parse and Fuzzer::CrashResistantMergeInternalStep around the parts that use ModuleRelativeValues objects. I then ran 1000 iterations of a test based on the first non-empty merge in compiler-rt/test/fuzzer/merge.test.

Mar 22 2021, 3:45 PM · Restricted Project
aarongreen updated the diff for D94512: Add ModuleInfo to TracePC.

Changed DsoInfo to ModuleInfo (and changed PrintModuleInfo to PrintModuleSummary). Moved asserts in CollectFeatures to unit tests.

Mar 22 2021, 9:15 AM · Restricted Project
aarongreen updated the diff for D94510: Tweak SimpleFastHash.
Mar 22 2021, 9:11 AM · Restricted Project
aarongreen updated the diff for D94509: Add fuzzer::DSORelativeValues.

Renamed DSO -> Module to be more in keeping with LLVM. Fixed a bug in calculating features that caused tests to fail when run with sanitizer instrumentation.

Mar 22 2021, 9:11 AM · Restricted Project
aarongreen updated the diff for D94508: Add functions to encode/decode feature files.
Mar 22 2021, 9:08 AM · Restricted Project

Mar 11 2021

aarongreen added inline comments to D94521: Add FuzzerRemote.
Mar 11 2021, 9:30 AM · Restricted Project

Mar 10 2021

aarongreen added a comment to D94517: Extract and expose FuzzerMonitor C interface..

Sorry if I'm misunderstanding the design. But how will we prevent stack trace skew from signals being delivered asynchronously?

i.e. We need a stack trace *now*, so we send a signal to that process. But by the time that process receives the signal, the IP is somewhere else, maybe a different function. So our stack trace is wrong.

Mar 10 2021, 9:03 AM · Restricted Project

Mar 8 2021

aarongreen added a comment to D94517: Extract and expose FuzzerMonitor C interface..

Interface change LGTM.

For the PID stuff, what is the plan for process-specific reports? To send a signal to the specified process to get a stack trace/memory profile?

Mar 8 2021, 1:44 PM · Restricted Project
aarongreen updated the diff for D94517: Extract and expose FuzzerMonitor C interface..
Mar 8 2021, 1:37 PM · Restricted Project
aarongreen added a comment to D94512: Add ModuleInfo to TracePC.

fyi: I'd like D97992 to land first; and for this change to be rebased on top of that.

Mar 8 2021, 10:20 AM · Restricted Project
aarongreen added inline comments to D97992: [crt][fuzzer] Fix up various numeric conversions.
Mar 8 2021, 10:17 AM · Restricted Project
aarongreen updated the diff for D97992: [crt][fuzzer] Fix up various numeric conversions.

Fixed indent added by clang-format.

Mar 8 2021, 10:17 AM · Restricted Project
aarongreen updated the diff for D97992: [crt][fuzzer] Fix up various numeric conversions.

Changed SumIncidence's type to double to reduce a lot of superfluous static_casting back a forth.

Mar 8 2021, 10:06 AM · Restricted Project

Mar 4 2021

aarongreen added inline comments to D97992: [crt][fuzzer] Fix up various numeric conversions.
Mar 4 2021, 8:54 PM · Restricted Project
aarongreen updated the diff for D97992: [crt][fuzzer] Fix up various numeric conversions.

Added a comment to the static_assert to make it -std=c++11 compatible.

Mar 4 2021, 8:53 PM · Restricted Project
aarongreen added inline comments to D97992: [crt][fuzzer] Fix up various numeric conversions.
Mar 4 2021, 8:45 PM · Restricted Project
aarongreen requested review of D97992: [crt][fuzzer] Fix up various numeric conversions.
Mar 4 2021, 5:10 PM · Restricted Project

Mar 3 2021

aarongreen added inline comments to D94514: Support module-relative values in FuzzerMerge.
Mar 3 2021, 1:14 PM · Restricted Project
aarongreen updated the diff for D94514: Support module-relative values in FuzzerMerge.

Addressed (most of) morehouse's comments. I still need to measure performance impact.

Mar 3 2021, 1:14 PM · Restricted Project
aarongreen added inline comments to D94512: Add ModuleInfo to TracePC.
Mar 3 2021, 1:03 PM · Restricted Project
aarongreen updated the diff for D94512: Add ModuleInfo to TracePC.

Addressing morehouse's comments. Also adjusted size and stack depth functions in TracePC to address some concerns that are in the following change (D94514), but are rleated to files and functions being changed here.

Mar 3 2021, 1:03 PM · Restricted Project

Feb 26 2021

aarongreen added inline comments to D96450: [libFuzzer] Use crash stack for fuchsia..
Feb 26 2021, 12:08 PM · Restricted Project

Feb 5 2021

aarongreen added a comment to D96148: Add remote fuzzing integration tests.

Note to reviewers: this still has a lot of test disabled as FIXMEs. While the preceding changes are in review, I hope to investigate and rectify some of these. Others require additional features to be added that I won't try to land ahead of this change, e.g. value-profile support.

Feb 5 2021, 8:53 AM · Restricted Project
aarongreen requested review of D96148: Add remote fuzzing integration tests.
Feb 5 2021, 8:52 AM · Restricted Project
aarongreen updated the diff for D96089: Move deprecated sancov functions to separate file..
Feb 5 2021, 8:46 AM · Restricted Project
aarongreen updated the diff for D94527: Add IPC for FuzzerRemote on Linux.
Feb 5 2021, 8:45 AM · Restricted Project
aarongreen updated the diff for D94526: Add IPC for FuzzerProxy on Linux.
Feb 5 2021, 8:45 AM · Restricted Project
aarongreen updated the diff for D94524: Add generic IPC support for Linux.
Feb 5 2021, 8:45 AM · Restricted Project
aarongreen updated the diff for D94523: Add FuzzerProxy.
Feb 5 2021, 8:44 AM · Restricted Project
aarongreen updated the diff for D94522: Add remote flags and external functions.
Feb 5 2021, 8:44 AM · Restricted Project
aarongreen updated the diff for D94521: Add FuzzerRemote.
Feb 5 2021, 8:44 AM · Restricted Project
aarongreen updated the diff for D94520: Refactor unit tests' CMakeFiles.txt.
Feb 5 2021, 8:43 AM · Restricted Project
aarongreen updated the diff for D94519: Add thread annotations..
Feb 5 2021, 8:42 AM · Restricted Project
aarongreen updated the diff for D94518: Move MallocFreeTracer to FuzzerMonitor.
Feb 5 2021, 8:42 AM · Restricted Project
aarongreen updated the diff for D94517: Extract and expose FuzzerMonitor C interface..
Feb 5 2021, 8:41 AM · Restricted Project
aarongreen updated the diff for D94515: Add ExternalFunctions to fuzzer::TestEnvironment..
Feb 5 2021, 8:41 AM · Restricted Project
aarongreen updated the diff for D94514: Support module-relative values in FuzzerMerge.
Feb 5 2021, 8:41 AM · Restricted Project
aarongreen updated the diff for D94512: Add ModuleInfo to TracePC.
Feb 5 2021, 8:40 AM · Restricted Project
aarongreen updated the diff for D94510: Tweak SimpleFastHash.
Feb 5 2021, 8:40 AM · Restricted Project
aarongreen updated the diff for D94509: Add fuzzer::DSORelativeValues.
Feb 5 2021, 8:38 AM · Restricted Project
aarongreen added inline comments to D94510: Tweak SimpleFastHash.
Feb 5 2021, 8:23 AM · Restricted Project

Feb 4 2021

aarongreen requested review of D96089: Move deprecated sancov functions to separate file..
Feb 4 2021, 4:09 PM · Restricted Project
aarongreen added inline comments to D94527: Add IPC for FuzzerRemote on Linux.
Feb 4 2021, 4:06 PM · Restricted Project
aarongreen updated the diff for D94527: Add IPC for FuzzerRemote on Linux.

Rebase

Feb 4 2021, 4:05 PM · Restricted Project
aarongreen updated the diff for D94526: Add IPC for FuzzerProxy on Linux.

Rebase

Feb 4 2021, 4:04 PM · Restricted Project
aarongreen updated the diff for D94524: Add generic IPC support for Linux.

Rebase

Feb 4 2021, 4:03 PM · Restricted Project
aarongreen updated the diff for D94523: Add FuzzerProxy.

Rebase

Feb 4 2021, 4:03 PM · Restricted Project
aarongreen updated the diff for D94522: Add remote flags and external functions.

Rebase

Feb 4 2021, 4:02 PM · Restricted Project
aarongreen updated the diff for D94521: Add FuzzerRemote.

Rebase

Feb 4 2021, 4:01 PM · Restricted Project
aarongreen updated the diff for D94520: Refactor unit tests' CMakeFiles.txt.

Rebase

Feb 4 2021, 4:00 PM · Restricted Project
aarongreen updated the diff for D94519: Add thread annotations..

Rebase

Feb 4 2021, 3:58 PM · Restricted Project
aarongreen updated the diff for D94518: Move MallocFreeTracer to FuzzerMonitor.

Rebase

Feb 4 2021, 3:58 PM · Restricted Project
aarongreen updated the diff for D94517: Extract and expose FuzzerMonitor C interface..

Rebase

Feb 4 2021, 3:56 PM · Restricted Project
aarongreen updated the diff for D94515: Add ExternalFunctions to fuzzer::TestEnvironment..

Rebase

Feb 4 2021, 3:56 PM · Restricted Project
aarongreen updated the diff for D94514: Support module-relative values in FuzzerMerge.

Rebase

Feb 4 2021, 3:55 PM · Restricted Project
aarongreen updated the diff for D94512: Add ModuleInfo to TracePC.

Rebase

Feb 4 2021, 3:55 PM · Restricted Project
aarongreen updated the diff for D94510: Tweak SimpleFastHash.

Combined two versions of SimpleFastHash into one.

Feb 4 2021, 3:54 PM · Restricted Project
aarongreen updated the diff for D94509: Add fuzzer::DSORelativeValues.
Feb 4 2021, 3:04 PM · Restricted Project
aarongreen added inline comments to D94508: Add functions to encode/decode feature files.
Feb 4 2021, 3:03 PM · Restricted Project
aarongreen updated the diff for D94508: Add functions to encode/decode feature files.

Address morehouse's comments.

Feb 4 2021, 3:02 PM · Restricted Project
aarongreen updated the diff for D94507: Bugfix for collecting features from very small DSOs..

Rebase

Feb 4 2021, 3:01 PM · Restricted Project
aarongreen updated the diff for D94506: Expand unit tests for fuzzer::Merger.

Just a rebase.

Feb 4 2021, 3:00 PM · Restricted Project

Feb 3 2021

aarongreen added inline comments to D94508: Add functions to encode/decode feature files.
Feb 3 2021, 11:14 AM · Restricted Project
aarongreen added a comment to D94510: Tweak SimpleFastHash.

Can you explain in the summary / commit message why this is needed? How do you intend to use it?

Feb 3 2021, 11:02 AM · Restricted Project