Page MenuHomePhabricator

AMDGPU/GlobalISel: Eliminate SelectVOP3Mods_f32
ClosedPublic

Authored by arsenm on Jan 24 2020, 10:46 AM.

Details

Summary

Trivial type predicates should be moved into the tablegen pattern
itself, and not checked inside complex patterns. This eliminates a
redundant complex pattern, and fixes select source modifiers for
GlobalISel.

I have further patches which fully handle select in tablegen and
remove all of the C++ selection, although it requires the ugliness to
support the entire range of legal register types.

Diff Detail

Event Timeline

arsenm created this revision.Jan 24 2020, 10:46 AM
This revision is now accepted and ready to land.Jan 24 2020, 11:06 AM