This is an archive of the discontinued LLVM Phabricator instance.

Differential D73251

[runtimes] Fix installation for LLVM_RUNTIME_DISTRIBUTION_COMPONENTS
ClosedPublic

Authored by smeenai on Jan 22 2020, 10:36 PM.

Details

Reviewers
compnerd
beanz
phosek
plotfi
Commits
rGb1da8eba60f6: [runtimes] Fix installation for LLVM_RUNTIME_DISTRIBUTION_COMPONENTS
Summary

The installation target we create should trigger the corresponding
installation target in the runtimes external project.

Diff Detail

Event Timeline

smeenai created this revision.Jan 22 2020, 10:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2020, 10:36 PM
Herald added subscribers: llvm-commits, mgorny. · View Herald Transcript
Harbormaster completed remote builds in B44667: Diff 239779.Jan 22 2020, 10:43 PM
phosek accepted this revision.Jan 24 2020, 7:10 PM

LGTM

This revision is now accepted and ready to land.Jan 24 2020, 7:10 PM
Closed by commit rGb1da8eba60f6: [runtimes] Fix installation for LLVM_RUNTIME_DISTRIBUTION_COMPONENTS (authored by smeenai). · Explain WhyJan 27 2020, 5:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
runtimes/
2 lines

Diff 240733

llvm/runtimes/CMakeLists.txt

Show First 20 Lines • Show All 424 Lines • ▼ Show 20 Lines function(runtime_register_target name target)
foreach(target_name IN LISTS SUB_COMPONENTS SUB_INSTALL_TARGETS) foreach(target_name IN LISTS SUB_COMPONENTS SUB_INSTALL_TARGETS)
set(${target_name}-${name} ${target_name}) set(${target_name}-${name} ${target_name})
list(APPEND ${name}_extra_targets ${target_name}-${name}) list(APPEND ${name}_extra_targets ${target_name}-${name})
endforeach() endforeach()
foreach(component ${LLVM_RUNTIME_DISTRIBUTION_COMPONENTS}) foreach(component ${LLVM_RUNTIME_DISTRIBUTION_COMPONENTS})
set(${component}-${name} ${component}) set(${component}-${name} ${component})
set(install-${component}-${name} ${component}) set(install-${component}-${name} install-${component})
list(APPEND ${name}_extra_targets ${component}-${name} install-${component}-${name}) list(APPEND ${name}_extra_targets ${component}-${name} install-${component}-${name})
endforeach() endforeach()
if(LLVM_INCLUDE_TESTS) if(LLVM_INCLUDE_TESTS)
set(runtimes-test-depends-${name} runtimes-test-depends) set(runtimes-test-depends-${name} runtimes-test-depends)
set(check-runtimes-${name} check-runtimes) set(check-runtimes-${name} check-runtimes)
list(APPEND ${name}_test_targets runtimes-test-depends-${name} check-runtimes-${name}) list(APPEND ${name}_test_targets runtimes-test-depends-${name} check-runtimes-${name})
foreach(target_name IN LISTS SUB_CHECK_TARGETS) foreach(target_name IN LISTS SUB_CHECK_TARGETS)
▲ Show 20 Lines • Show All 153 Lines • Show Last 20 Lines