This is an archive of the discontinued LLVM Phabricator instance.

Differential D73180

Ignore llvm/tools/mlir
AbandonedPublic

Authored by psamolysov on Jan 22 2020, 5:47 AM.

Download Raw Diff

Details

Reviewers

mehdi_amini

Group Reviewers

Restricted Project

Summary

Even though MLIR has been migrated to the monorepo, to let it be built we need to create a symlink inside the 'llvm/tools' directory. It looks like this directory should be ignored by Git since it is tracked independently as a part of the monorepo.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

psamolysov created this revision.Jan 22 2020, 5:47 AM

Herald added subscribers: llvm-commits, aartbik, rriddle. · View Herald TranscriptJan 22 2020, 5:47 AM

psamolysov edited the summary of this revision. (Show Details)Jan 22 2020, 5:47 AM

Even though MLIR has been migrated to the monorepo, to let it be built we need to create a symlink inside the 'llvm/tools' directory. It looks like this directory should be ignored by Git since it is tracked independently as a part of the monorepo.

Are there any plans to fix this so that it can be built with -DLLVM_ENABLE_PROJECTS like the other sub-projects?

In D73180#1834239, @tstellar wrote:

Even though MLIR has been migrated to the monorepo, to let it be built we need to create a symlink inside the 'llvm/tools' directory. It looks like this directory should be ignored by Git since it is tracked independently as a part of the monorepo.

Are there any plans to fix this so that it can be built with -DLLVM_ENABLE_PROJECTS like the other sub-projects?

This is already the case, there is no need for a symlink: https://mlir.llvm.org/getting_started/

This revision now requires changes to proceed.Jan 22 2020, 9:41 AM

@mehdi_amini I didn't know about this option, sorry for incorrect message. But there has been another workflow for long time with symlinking projects into llvm (I use this approach as for clang, polly and lld) and I think it could be suitable to ignore llvm/tools/mlir as it did for other subprojects: polly, clang, etc.

I don't think the symlink approach is anything but an artifact of how the project was structured before the monorepo.

It works "by accident" with MLIR at this point, as this was the easiest way for me to hook into CMake when I merged MLIR in the monorepo, otherwise I wouldn't have supported this.

psamolysov abandoned this revision.May 29 2020, 8:10 AM

Herald added a subscriber: stephenneuendorffer. · View Herald TranscriptMay 29 2020, 8:10 AM

Revision Contents

Path

Size

llvm/

.gitignore

2 lines

Diff 239554

llvm/.gitignore

	Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Lines
	# Clang, which is tracked independently.			# Clang, which is tracked independently.
	tools/clang			tools/clang
	# LLDB, which is tracked independently.			# LLDB, which is tracked independently.
	tools/lldb			tools/lldb
	# lld, which is tracked independently.			# lld, which is tracked independently.
	tools/lld			tools/lld
	# llgo, which is tracked independently.			# llgo, which is tracked independently.
	tools/llgo			tools/llgo
				# MLIR, which is tracked independently.
				tools/mlir
	# Polly, which is tracked independently.			# Polly, which is tracked independently.
	tools/polly			tools/polly
	# avrlit, which is tracked independently.			# avrlit, which is tracked independently.
	tools/avrlit			tools/avrlit
	# Sphinx build tree, if building in-source dir.			# Sphinx build tree, if building in-source dir.
	docs/_build			docs/_build
	# VS2017 and VSCode config files.			# VS2017 and VSCode config files.
	.vscode			.vscode
	Show All 9 Lines