[clang][index] Index the injected class name types.

[hokein]

Summary

Currently, we (clangd) are missing this kind of references.

[merge_guards_bot]

Unit tests: pass. 62058 tests passed, 0 failed and 784 were skipped.

clang-tidy: unknown.

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

[kadircet]

Thanks this LG (please apply clang-format fixes though)

Have you checked if this class is missing any other typelocs?

[hokein]

clang-format the code.

[hokein]

In D73109#1831399, @kadircet wrote:

Have you checked if this class is missing any other typelocs?

I haven't checked it in details, but the injected class name is an obvious missing case.

[merge_guards_bot]

Unit tests: pass. 62058 tests passed, 0 failed and 784 were skipped.

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

clang/lib/Index/IndexTypeSourceInfo.cpp

bool VisitDeducedTemplateSpecializationTypeLoc(DeducedTemplateSpecializationTypeLoc TL) {
     if (!T)
       return true;
     HandleTemplateSpecializationTypeLoc(
         T->getTemplateName(), TL.getTemplateNameLoc(), T->getAsCXXRecordDecl(),
         /*IsTypeAlias=*/false);
     return true;
   }
 
+  bool VisitInjectedClassNameTypeLoc(InjectedClassNameTypeLoc TL) {
+    return IndexCtx.handleReference(TL.getDecl(), TL.getNameLoc(), Parent,
+                                    ParentDC, SymbolRoleSet(), Relations);
+  }
+
   bool VisitDependentNameTypeLoc(DependentNameTypeLoc TL) {
     const DependentNameType *DNT = TL.getTypePtr();
     const NestedNameSpecifier *NNS = DNT->getQualifier();
     const Type *T = NNS->getAsType();
     if (!T)
       return true;
     const TemplateSpecializationType *TST =
         T->getAs<TemplateSpecializationType>();

clang/unittests/Index/IndexTests.cpp

EXPECT_THAT(
                 HasRole(SymbolRole::NameReference), WrittenAt(Position(3, 7))),
           AllOf(QName("Foo::~Foo"), Kind(SymbolKind::Destructor),
                 WrittenAt(Position(4, 7))),
           AllOf(QName("Foo"), Kind(SymbolKind::Struct),
                 HasRole(SymbolRole::NameReference),
                 WrittenAt(Position(4, 8)))));
 }
 
+TEST(IndexTest, InjecatedNameClass) {
+  std::string Code = R"cpp(
+    template <typename T>
+    class Foo {
+      void f(Foo x);
+    };
+  )cpp";
+  auto Index = std::make_shared<Indexer>();
+  IndexingOptions Opts;
+  tooling::runToolOnCode(std::make_unique<IndexAction>(Index, Opts), Code);
+  EXPECT_THAT(Index->Symbols,
+              UnorderedElementsAre(AllOf(QName("Foo"), Kind(SymbolKind::Class),
+                                         WrittenAt(Position(3, 11))),
+                                   AllOf(QName("Foo::f"),
+                                         Kind(SymbolKind::InstanceMethod),
+                                         WrittenAt(Position(4, 12))),
+                                   AllOf(QName("Foo"), Kind(SymbolKind::Class),
+                                         HasRole(SymbolRole::Reference),
+                                         WrittenAt(Position(4, 14)))));
+}
+
 } // namespace
 } // namespace index
 } // namespace clang