Page MenuHomePhabricator

[clang][index] Index the injected class name types.
ClosedPublic

Authored by hokein on Jan 21 2020, 7:44 AM.

Details

Summary

Currently, we (clangd) are missing this kind of references.

Diff Detail

Event Timeline

hokein created this revision.Jan 21 2020, 7:44 AM

Unit tests: pass. 62058 tests passed, 0 failed and 784 were skipped.

clang-tidy: unknown.

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

kadircet accepted this revision.Jan 21 2020, 8:05 AM

Thanks this LG (please apply clang-format fixes though)

Have you checked if this class is missing any other typelocs?

This revision is now accepted and ready to land.Jan 21 2020, 8:05 AM
hokein updated this revision to Diff 239504.Jan 22 2020, 12:47 AM

clang-format the code.

Have you checked if this class is missing any other typelocs?

I haven't checked it in details, but the injected class name is an obvious missing case.

This revision was automatically updated to reflect the committed changes.

Unit tests: pass. 62058 tests passed, 0 failed and 784 were skipped.

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml