This is an archive of the discontinued LLVM Phabricator instance.

Differential D72862

[libcxx] Temporarily switch back to pthread backend for Fuchsia
ClosedPublic

Authored by phosek on Jan 16 2020, 12:15 PM.

Details

Reviewers
EricWF
leonardchan
mclow.lists
Commits
rG9050d0fb593c: [libcxx] Temporarily switch back to pthread backend for Fuchsia
Summary

We switched to C11 thread API on Fuchsia in ab9aefe, but further
testing showed that Fuchsia's C11 mutex implementation needs a few
improvements for this to be usable, so we temporarily switch back
to the pthread implementation until those issues are addressed.

Diff Detail

Event Timeline

phosek created this revision.Jan 16 2020, 12:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 16 2020, 12:15 PM
Herald added subscribers: libcxx-commits, jfb, ldionne, christof. · View Herald Transcript
EricWF accepted this revision.Jan 16 2020, 12:20 PM

Can you open a bug somewhere and then add a // FIXME or TODO comment explaining that C11 is what we eventually want?

This revision is now accepted and ready to land.Jan 16 2020, 12:20 PM
Herald added a reviewer: mclow.lists. · View Herald TranscriptJan 16 2020, 12:20 PM
phosek updated this revision to Diff 238627.Jan 16 2020, 2:52 PM

Done

Closed by commit rG9050d0fb593c: [libcxx] Temporarily switch back to pthread backend for Fuchsia (authored by phosek). · Explain WhyJan 16 2020, 2:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
libcxx/
include/
3 lines

Diff 238633

libcxx/include/__config

Show First 20 Lines • Show All 1,119 Lines • ▼ Show 20 Lines# if defined(__FreeBSD__) || \
defined(__linux__) || \ defined(__linux__) || \
defined(__GNU__) || \ defined(__GNU__) || \
defined(__APPLE__) || \ defined(__APPLE__) || \
defined(__CloudABI__) || \ defined(__CloudABI__) || \
defined(__sun__) || \ defined(__sun__) || \
(defined(__MINGW32__) && __has_include(<pthread.h>)) (defined(__MINGW32__) && __has_include(<pthread.h>))
# define _LIBCPP_HAS_THREAD_API_PTHREAD # define _LIBCPP_HAS_THREAD_API_PTHREAD
# elif defined(__Fuchsia__) # elif defined(__Fuchsia__)
# define _LIBCPP_HAS_THREAD_API_C11 // TODO(44575): Switch to C11 thread API when possible.
# define _LIBCPP_HAS_THREAD_API_PTHREAD
# elif defined(_LIBCPP_WIN32API) # elif defined(_LIBCPP_WIN32API)
# define _LIBCPP_HAS_THREAD_API_WIN32 # define _LIBCPP_HAS_THREAD_API_WIN32
# else # else
# error "No thread API" # error "No thread API"
# endif // _LIBCPP_HAS_THREAD_API # endif // _LIBCPP_HAS_THREAD_API
#endif // _LIBCPP_HAS_NO_THREADS #endif // _LIBCPP_HAS_NO_THREADS
#if defined(_LIBCPP_HAS_THREAD_API_PTHREAD) #if defined(_LIBCPP_HAS_THREAD_API_PTHREAD)
▲ Show 20 Lines • Show All 388 Lines • Show Last 20 Lines