This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Add missing dependency on LinalgUtils
ClosedPublic

Authored by GMNGeoffrey on Jan 15 2020, 7:09 PM.

Details

Summary

This missing dependency causes link-time failures in binaries
including LinalgTransforms. We've added the dependency
further up, where we use this library in our project
(https://github.com/google/iree/commit/df6b77a46efa939a496012a186d3d94dec35d8c3),
but it more properly belongs here.

Diff Detail

Event Timeline

GMNGeoffrey created this revision.Jan 15 2020, 7:09 PM

This is my first contribution now that MLIR has moved to the monorepo. Feedback on what I got wrong welcome

mehdi_amini added a comment.EditedJan 15 2020, 7:15 PM

<snip>

Unit tests: pass. 61909 tests passed, 0 failed and 782 were skipped.

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

GMNGeoffrey updated this revision to Diff 238410.EditedJan 15 2020, 7:44 PM

Remove LinalgUtils dependency from test transforms

This was masking the missing dependency in LinalgTransforms

LinalgToSpirv is only in the IREE project, but I removed the extra dependency from the test transforms, which I think was masking this error as you describe.

Unit tests: pass. 61909 tests passed, 0 failed and 782 were skipped.

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

marbre added a subscriber: marbre.Jan 16 2020, 2:04 AM
nicolasvasilache accepted this revision.Jan 16 2020, 5:09 AM

Thanks Geoff!

This revision is now accepted and ready to land.Jan 16 2020, 5:09 AM
This revision was automatically updated to reflect the committed changes.