This is an archive of the discontinued LLVM Phabricator instance.

[Driver] Ignore -fno-semantic-interposition
ClosedPublic

Authored by MaskRay on Jan 14 2020, 10:51 AM.

Details

Summary

Fedora wants to build projects with -fno-semantic-interposition (e.g.
https://fedoraproject.org/wiki/Changes/PythonNoSemanticInterpositionSpeedup),
which is supported by GCC>=5.

Clang's current behavior is similar to -fno-semantic-interposition and
the end goal is to make it more so
(https://lists.llvm.org/pipermail/llvm-dev/2016-November/107625.html).
Ignore this option.

We should let users know -fsemantic-interposition is not currently
supported, so it should remain a hard error.

Diff Detail

Event Timeline

MaskRay created this revision.Jan 14 2020, 10:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2020, 10:51 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Unit tests: pass. 61849 tests passed, 0 failed and 781 were skipped.

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

This revision is now accepted and ready to land.Jan 14 2020, 11:56 AM
MaskRay updated this revision to Diff 238065.Jan 14 2020, 11:56 AM

Use Flag<> instead

LGTM

I don't follow Fedora news. It is just that a friend informed me of this -fno-semantic-interposition movement two days ago and I postulated that it was your motivation to ping that patch...

@MaskRay: is that okay with you if I start implementing -fsemantic-interposition based on dso_preemptable?

This revision was automatically updated to reflect the committed changes.

Unit tests: pass. 61856 tests passed, 0 failed and 781 were skipped.

clang-tidy: unknown.

clang-format: pass.

Build artifacts: diff.json, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

MaskRay added a comment.EditedJan 14 2020, 12:14 PM

@MaskRay: is that okay with you if I start implementing -fsemantic-interposition based on dso_preemptable?

I haven't done anything in this area. Go ahead:) I'd like to help or review if you need anything from me.

Ah, I'll want to figure out how to emit local aliases to dso_local as a follow-up of D72197, but that should be orthogonal to what you want to do.