Page MenuHomePhabricator

Built-in functions for AMDGPU MFMA instructions.
ClosedPublic

Authored by kpyzhov on Jan 14 2020, 10:42 AM.

Diff Detail

Event Timeline

kpyzhov created this revision.Jan 14 2020, 10:42 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 14 2020, 10:42 AM

LGTM

llvm/lib/Target/AMDGPU/AMDGPU.td
487 ↗(On Diff #238025)

We already have the HasMAIInsts feature

yaxunl accepted this revision.Jan 15 2020, 7:53 AM

LGTM. Thanks.

This revision is now accepted and ready to land.Jan 15 2020, 7:53 AM
kpyzhov updated this revision to Diff 238259.Jan 15 2020, 7:54 AM
kpyzhov added a reviewer: arsenm.
arsenm requested changes to this revision.Jan 15 2020, 7:58 AM

Having two subtarget features for the same feature is an issue

This revision now requires changes to proceed.Jan 15 2020, 7:58 AM
kpyzhov updated this revision to Diff 238263.Jan 15 2020, 8:04 AM
arsenm accepted this revision.Jan 15 2020, 8:54 AM

LGTM

This revision is now accepted and ready to land.Jan 15 2020, 8:54 AM

Having two subtarget features for the same feature is an issue

?

This revision was automatically updated to reflect the committed changes.

This seems to break check-clang everywhere. If the fix isn't obvious, please revert and analyze asynchronously.

Thanks for reporting this. Somehow I managed to push empty test files. I'll push the fix soon.

Things have been broken for 1.5 hours now. Time to revert?

I've pushed the fix already. Is something still broken?