This is an archive of the discontinued LLVM Phabricator instance.

Differential D72565

adding __has_feature support for left c++ type_traits
AbandonedPublic

Authored by kamleshbhalui on Jan 12 2020, 4:28 AM.

Details

Reviewers
rsmith
aaron.ballman
dblaikie
ldionne
erik.pilkington
Summary

adding __has_feature support for left c++ type_traits.

fixes this
https://bugs.llvm.org/show_bug.cgi?id=44517

Diff Detail

Event Timeline

kamleshbhalui created this revision.Jan 12 2020, 4:28 AM
Herald added subscribers: cfe-commits, dexonsmith. · View Herald TranscriptJan 12 2020, 4:28 AM
kamleshbhalui added a reviewer: erik.pilkington.Jan 12 2020, 4:30 AM
dblaikie added a comment.Jan 12 2020, 9:24 AM

Probably needs test coverage (perhaps check the commits that added other feature tests - there's probably somewhere you can plugin tests in a similar way to plugging in the feature tests themselves)

rsmith requested changes to this revision.Jan 12 2020, 10:34 AM
rsmith added inline comments.
clang/include/clang/Basic/Features.def
191–192

Please see this comment. __has_builtin should be used to detect these type traits, per the documentation (https://clang.llvm.org/docs/LanguageExtensions.html#type-trait-primitives and https://clang.llvm.org/docs/LanguageExtensions.html#has-builtin), and already works for this purpose.

This revision now requires changes to proceed.Jan 12 2020, 10:34 AM
kamleshbhalui abandoned this revision.EditedJan 12 2020, 5:46 PM
not an issue since __has_builtin does the work.
i.e. __has_builtin(__is_same)

Revision Contents

PathSize
clang/
include/
clang/
Basic/
4 lines

Diff 237531

clang/include/clang/Basic/Features.def

Show First 20 Lines • Show All 182 Lines • ▼ Show 20 Lines
// the SD-6 macro and not a __has_feature check. // the SD-6 macro and not a __has_feature check.
// C++ TSes // C++ TSes
// FEATURE(cxx_runtime_arrays, LangOpts.CPlusPlusTSArrays) // FEATURE(cxx_runtime_arrays, LangOpts.CPlusPlusTSArrays)
// FEATURE(cxx_concepts, LangOpts.CPlusPlusTSConcepts) // FEATURE(cxx_concepts, LangOpts.CPlusPlusTSConcepts)
// FIXME: Should this be __has_feature or __has_extension? // FIXME: Should this be __has_feature or __has_extension?
// FEATURE(raw_invocation_type, LangOpts.CPlusPlus) // FEATURE(raw_invocation_type, LangOpts.CPlusPlus)
// Type traits // Type traits
// N.B. Additional type traits should not be added to the following list. // N.B. Additional type traits should not be added to the following list.
// Instead, they should be detected by has_builtin. // Instead, they should be detected by has_builtin.
rsmithUnsubmitted
Not Done
ReplyInline Actions

Please see this comment. __has_builtin should be used to detect these type traits, per the documentation (https://clang.llvm.org/docs/LanguageExtensions.html#type-trait-primitives and https://clang.llvm.org/docs/LanguageExtensions.html#has-builtin), and already works for this purpose.

rsmith: Please see this comment. `__has_builtin` should be used to detect these type traits, per the…
FEATURE(has_nothrow_assign, LangOpts.CPlusPlus) FEATURE(has_nothrow_assign, LangOpts.CPlusPlus)
FEATURE(has_nothrow_copy, LangOpts.CPlusPlus) FEATURE(has_nothrow_copy, LangOpts.CPlusPlus)
FEATURE(has_nothrow_constructor, LangOpts.CPlusPlus) FEATURE(has_nothrow_constructor, LangOpts.CPlusPlus)
FEATURE(has_trivial_assign, LangOpts.CPlusPlus) FEATURE(has_trivial_assign, LangOpts.CPlusPlus)
FEATURE(has_trivial_copy, LangOpts.CPlusPlus) FEATURE(has_trivial_copy, LangOpts.CPlusPlus)
FEATURE(has_trivial_constructor, LangOpts.CPlusPlus) FEATURE(has_trivial_constructor, LangOpts.CPlusPlus)
FEATURE(has_trivial_destructor, LangOpts.CPlusPlus) FEATURE(has_trivial_destructor, LangOpts.CPlusPlus)
FEATURE(has_virtual_destructor, LangOpts.CPlusPlus) FEATURE(has_virtual_destructor, LangOpts.CPlusPlus)
Show All 10 Lines
FEATURE(is_pod, LangOpts.CPlusPlus) FEATURE(is_pod, LangOpts.CPlusPlus)
FEATURE(is_polymorphic, LangOpts.CPlusPlus) FEATURE(is_polymorphic, LangOpts.CPlusPlus)
FEATURE(is_sealed, LangOpts.CPlusPlus &&LangOpts.MicrosoftExt) FEATURE(is_sealed, LangOpts.CPlusPlus &&LangOpts.MicrosoftExt)
FEATURE(is_trivial, LangOpts.CPlusPlus) FEATURE(is_trivial, LangOpts.CPlusPlus)
FEATURE(is_trivially_assignable, LangOpts.CPlusPlus) FEATURE(is_trivially_assignable, LangOpts.CPlusPlus)
FEATURE(is_trivially_constructible, LangOpts.CPlusPlus) FEATURE(is_trivially_constructible, LangOpts.CPlusPlus)
FEATURE(is_trivially_copyable, LangOpts.CPlusPlus) FEATURE(is_trivially_copyable, LangOpts.CPlusPlus)
FEATURE(is_union, LangOpts.CPlusPlus) FEATURE(is_union, LangOpts.CPlusPlus)
FEATURE(is_same, LangOpts.CPlusPlus)
FEATURE(is_function, LangOpts.CPlusPlus)
FEATURE(is_assignable, LangOpts.CPlusPlus)
FEATURE(is_nothrow_constructible, LangOpts.CPlusPlus)
FEATURE(modules, LangOpts.Modules) FEATURE(modules, LangOpts.Modules)
FEATURE(safe_stack, LangOpts.Sanitize.has(SanitizerKind::SafeStack)) FEATURE(safe_stack, LangOpts.Sanitize.has(SanitizerKind::SafeStack))
FEATURE(shadow_call_stack, FEATURE(shadow_call_stack,
LangOpts.Sanitize.has(SanitizerKind::ShadowCallStack)) LangOpts.Sanitize.has(SanitizerKind::ShadowCallStack))
FEATURE(tls, PP.getTargetInfo().isTLSSupported()) FEATURE(tls, PP.getTargetInfo().isTLSSupported())
FEATURE(underlying_type, LangOpts.CPlusPlus) FEATURE(underlying_type, LangOpts.CPlusPlus)
// C11 features supported by other languages as extensions. // C11 features supported by other languages as extensions.
Show All 31 Lines