This is an archive of the discontinued LLVM Phabricator instance.

[ARM,MVE] Fix valid immediate range for vsliq_n.
ClosedPublic

Authored by simon_tatham on Jan 9 2020, 5:07 AM.

Details

Summary

In common with most MVE immediate shift instructions, the left shift
takes an immediate in the range [0,n-1], while the right shift takes
one in the range [1,n]. I had absent-mindedly made them both the
latter.

While I'm here, I've added a set of regression tests checking both
ends of the immediate range for a representative sample of the
immediate shifts.

Event Timeline

simon_tatham created this revision.Jan 9 2020, 5:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 9 2020, 5:07 AM
dmgreen accepted this revision.Jan 9 2020, 5:47 AM

Nice test. LGTM

clang/test/Sema/arm-mve-immediates.c
182

This set is repeated from above?

This revision is now accepted and ready to land.Jan 9 2020, 5:47 AM
simon_tatham closed this revision.Jan 9 2020, 7:41 AM
simon_tatham marked an inline comment as done.

Closed by rGd857e114b5e04f5143485a5aea7ad9b283768692. (I managed to leave off the commit message footer, sorry.)