This is an archive of the discontinued LLVM Phabricator instance.

[mlir][spirv] Update SPIR-V enums and ops with availability spec
ClosedPublic

Authored by antiagainst on Jan 2 2020, 10:28 AM.

Details

Summary

This commit updates gen_spirv_dialect.py to query the grammar and
generate availability spec for various enum attribute definitions
and all defined ops.

Diff Detail

Event Timeline

antiagainst created this revision.Jan 2 2020, 10:28 AM

Unit tests: pass. 61172 tests passed, 0 failed and 729 were skipped.

clang-tidy: fail. Please fix clang-tidy findings.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

mravishankar accepted this revision.Jan 2 2020, 10:43 AM

This is awesome! Fantastic work!

mlir/utils/spirv/gen_spirv_dialect.py
141

Nit: rename this "get_capability_mapping". Just makes it clearer

400

Nit: use "capability_mapping" for variable name?

This revision is now accepted and ready to land.Jan 2 2020, 10:43 AM
antiagainst marked 2 inline comments as done.

Address comments

Unit tests: pass. 61172 tests passed, 0 failed and 729 were skipped.

clang-tidy: fail. Please fix clang-tidy findings.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

This revision was automatically updated to reflect the committed changes.