Page MenuHomePhabricator

[mlir] NFC: Fix broken links in docs
ClosedPublic

Authored by kiszk on Jan 1 2020, 8:58 PM.

Details

Summary

This commit fixes missing links that are caused by the repository movement.

Diff Detail

Event Timeline

kiszk created this revision.Jan 1 2020, 8:58 PM
kiszk retitled this revision from [mlir] NFC: Fix broken links to [mlir] NFC: Fix broken links in docs.Jan 1 2020, 8:59 PM
Jim accepted this revision.Jan 1 2020, 9:10 PM
This revision is now accepted and ready to land.Jan 1 2020, 9:10 PM
rriddle requested changes to this revision.Jan 1 2020, 9:22 PM
rriddle added inline comments.
mlir/docs/OpDefinitions.md
1206–1210

Can we use relative paths for these instead? Same with the fixes in the other files.

This revision now requires changes to proceed.Jan 1 2020, 9:22 PM
rriddle added inline comments.Jan 1 2020, 9:23 PM
mlir/docs/OpDefinitions.md
1206–1210

(I mean for the ones where it makes sense, i.e. StringAttr, etc.)

kiszk updated this revision to Diff 235825.Jan 1 2020, 9:46 PM
  • address review comment to use relative paths
kiszk added inline comments.Jan 1 2020, 9:47 PM
mlir/docs/OpDefinitions.md
1206–1210

Sure, I will address this

rriddle accepted this revision.Jan 1 2020, 9:49 PM

Approval pending comments addressed.

This revision is now accepted and ready to land.Jan 1 2020, 9:49 PM
jpienaar accepted this revision.Jan 2 2020, 8:30 AM

Thanks

kiszk added a comment.EditedJan 2 2020, 9:39 AM

I do not have commit rights to the repository. Could someone commit this change?
Kazuaki Ishizaki <ishizaki@jp.ibm.com>

This revision was automatically updated to reflect the committed changes.