Adding strict FFLOOR/FCEIL/FTRUNC/FRINT/FNEARBYINT support for X86 backend
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Can you replace “scale” with “round” in the review title and the test name. These aren’t scale instructions except that avx512 has vrndscale, but we aren’t using the scaling part
Comment Actions
LGTM with that one comment fixed.
llvm/lib/Target/X86/X86ISelDAGToDAG.cpp | ||
---|---|---|
932 | This is intented one extra space. |
llvm/lib/Target/X86/X86ISelDAGToDAG.cpp | ||
---|---|---|
932 | Hi, Craig. I think the format is right. |
llvm/lib/Target/X86/X86ISelDAGToDAG.cpp | ||
---|---|---|
932 | I used clang-format to modify the format. |
llvm/lib/Target/X86/X86ISelDAGToDAG.cpp | ||
---|---|---|
932 | sorry. You’re right. I got confused by the braces. |
This is intented one extra space.