This is an archive of the discontinued LLVM Phabricator instance.

[X86] Add strict float for round operation
ClosedPublic

Authored by LiuChen3 on Dec 30 2019, 7:43 PM.

Details

Summary

Adding strict FFLOOR/FCEIL/FTRUNC/FRINT/FNEARBYINT support for X86 backend

Diff Detail

Event Timeline

LiuChen3 created this revision.Dec 30 2019, 7:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 30 2019, 7:43 PM

Can you replace “scale” with “round” in the review title and the test name. These aren’t scale instructions except that avx512 has vrndscale, but we aren’t using the scaling part

Can you replace “scale” with “round” in the review title and the test name. These aren’t scale instructions except that avx512 has vrndscale, but we aren’t using the scaling part

OK.

LiuChen3 updated this revision to Diff 235672.Dec 30 2019, 8:21 PM
LiuChen3 retitled this revision from [X86] Add strict float for scale operation to [X86] Add strict float for round operation.

Address comments

craig.topper accepted this revision.Dec 30 2019, 10:16 PM

LGTM with that one comment fixed.

llvm/lib/Target/X86/X86ISelDAGToDAG.cpp
932

This is intented one extra space.

This revision is now accepted and ready to land.Dec 30 2019, 10:16 PM
LiuChen3 marked an inline comment as done.Dec 31 2019, 1:26 AM
LiuChen3 added inline comments.
llvm/lib/Target/X86/X86ISelDAGToDAG.cpp
932

Hi, Craig. I think the format is right.

LiuChen3 marked an inline comment as done.Dec 31 2019, 1:30 AM
LiuChen3 added inline comments.
llvm/lib/Target/X86/X86ISelDAGToDAG.cpp
932

I used clang-format to modify the format.

craig.topper added inline comments.Dec 31 2019, 8:41 AM
llvm/lib/Target/X86/X86ISelDAGToDAG.cpp
932

sorry. You’re right. I got confused by the braces.

This revision was automatically updated to reflect the committed changes.