Page MenuHomePhabricator

[Attributor] Propagate known information from `checkForAllCallSites`
ClosedPublic

Authored by jdoerfert on Dec 30 2019, 2:36 PM.

Details

Summary

If we know that all call sites have been processed we can derive an
early fixpoint. The use in this patch is likely not to trigger right now
but a follow up patch will make use of it.

Diff Detail

Event Timeline

jdoerfert created this revision.Dec 30 2019, 2:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 30 2019, 2:36 PM

Unit tests: pass. 61153 tests passed, 0 failed and 728 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

baziotis added inline comments.Dec 30 2019, 4:07 PM
llvm/lib/Transforms/IPO/Attributor.cpp
2953

Maybe something similar can be done for AAValueSimplifyArgument?

jdoerfert marked an inline comment as done.Dec 31 2019, 12:15 AM
jdoerfert added inline comments.
llvm/lib/Transforms/IPO/Attributor.cpp
2953

True, probably for others as well. Though, especially AAValueSimplifyArgument is somewhat in flux right now. The follow up applies this to AANoRecurse in order to get rid of the last FIXMEs in the norecurse test.

baziotis added inline comments.Dec 31 2019, 8:18 AM
llvm/lib/Transforms/IPO/Attributor.cpp
2953

Ok, good, I'll take a look.

uenoku accepted this revision.Dec 31 2019, 8:47 AM

LGTM from me.

This revision is now accepted and ready to land.Dec 31 2019, 8:47 AM
baziotis accepted this revision.Dec 31 2019, 9:52 AM

LGTM too.

This revision was automatically updated to reflect the committed changes.