Page MenuHomePhabricator

[mlir][Linalg] Delete unused LinalgLibraryOps.td - NFC
ClosedPublic

Authored by nicolasvasilache on Dec 30 2019, 12:42 PM.

Details

Summary

This has been previously renamed to LinalgStructuredOps.td

Diff Detail

Event Timeline

nicolasvasilache retitled this revision from [mlir][Linalg] Delete unused LinalgLibraryOps.td to [mlir][Linalg] Delete unused LinalgLibraryOps.td - NFC.
rriddle accepted this revision.Dec 30 2019, 12:47 PM

Are there any CMAKE files that need to be updated?

This revision is now accepted and ready to land.Dec 30 2019, 12:47 PM
jpienaar accepted this revision.Dec 30 2019, 12:48 PM

Unit tests: pass. 61153 tests passed, 0 failed and 728 were skipped.

clang-tidy: fail. Please fix clang-tidy findings.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

ftynse accepted this revision.Dec 30 2019, 1:02 PM
nicolasvasilache added a comment.EditedDec 30 2019, 1:28 PM

clang-tidy findings on unrelated parts of LLVM, what's the procedure here?
Edit: these are just warnings, https://results.llvm-merge-guard.org/amd64_debian_testing_clang8-702/clang-tidy.txt

I see a build failure at: https://reviews.llvm.org/harbormaster/build/43712/
But there are no logs or messages that would help me debug.
Clicking on the jenkins instance asks for a login/password.

Asking on the discord channel.

Unit tests: pass. 61153 tests passed, 0 failed and 728 were skipped.

clang-tidy: fail. Please fix clang-tidy findings.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml