This is an archive of the discontinued LLVM Phabricator instance.

Differential D71958

Update mlir/CMakeLists.txt to install *.td files
ClosedPublic

Authored by kernhanda on Dec 28 2019, 2:26 AM.

Details

Reviewers
schweitz
mehdi_amini
jpienaar
ftynse
Commits
rGcde071c4bfb7: [mlir] Update mlir/CMakeLists.txt to install *.td files
Summary

Currently when you build the install target, TableGen files don't get installed.

TableGen files are needed when authoring new MLIR dialects, but right now they're missing when using the pre-built binaries.

Diff Detail

Event Timeline

kernhanda created this revision.Dec 28 2019, 2:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 28 2019, 2:26 AM
Herald added subscribers: llvm-commits, antiagainst, shauheen and 3 others. · View Herald Transcript
ftynse added a subscriber: ftynse.Dec 28 2019, 2:43 AM

Could you please specify why you need them installed in the commit description?

kernhanda edited the summary of this revision. (Show Details)Dec 28 2019, 10:01 AM
In D71958#1797861, @ftynse wrote:

Could you please specify why you need them installed in the commit description?

Done

ftynse accepted this revision.Dec 28 2019, 10:04 AM
This revision is now accepted and ready to land.Dec 28 2019, 10:04 AM
kernhanda added a comment.Dec 28 2019, 1:25 PM

I don't have commit access, so someone else will have to submit this.

ftynse added a comment.Dec 28 2019, 2:22 PM

I can commit it for you. Please let me know what name and email to associate your commit with, I don't seem to find them in the description.

kernhanda added a comment.Dec 28 2019, 3:14 PM
In D71958#1798099, @ftynse wrote:

I can commit it for you. Please let me know what name and email to associate your commit with, I don't seem to find them in the description.

name: Kern Handa
email: kern dot handa at gmail dot com

Thanks! Let me know if there's a better way to provide commit author info in the future.

Closed by commit rGcde071c4bfb7: [mlir] Update mlir/CMakeLists.txt to install *.td files (authored by kernhanda, committed by ftynse). · Explain WhyDec 29 2019, 9:14 AM
This revision was automatically updated to reflect the committed changes.
ftynse added a comment.Dec 29 2019, 9:24 AM

Try sending patches with arc diff, I've been told it preserves committer info. Otherwise, I pick up the address from wherever I can, e.g. the signed-off-by field or the history of commits from the same person.

Revision Contents

PathSize
mlir/
1 line

Diff 235468

mlir/CMakeLists.txt

Show First 20 Lines • Show All 80 Lines • ▼ Show 20 Lines
if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY) if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)
install(DIRECTORY include/mlir include/mlir-c install(DIRECTORY include/mlir include/mlir-c
DESTINATION include DESTINATION include
COMPONENT mlir-headers COMPONENT mlir-headers
FILES_MATCHING FILES_MATCHING
PATTERN "*.h" PATTERN "*.h"
PATTERN "*.inc" PATTERN "*.inc"
PATTERN "*.td"
PATTERN "LICENSE.TXT" PATTERN "LICENSE.TXT"
) )
install(DIRECTORY ${MLIR_INCLUDE_DIR}/mlir ${MLIR_INCLUDE_DIR}/mlir-c install(DIRECTORY ${MLIR_INCLUDE_DIR}/mlir ${MLIR_INCLUDE_DIR}/mlir-c
DESTINATION include DESTINATION include
COMPONENT mlir-headers COMPONENT mlir-headers
FILES_MATCHING FILES_MATCHING
PATTERN "*.h" PATTERN "*.h"
Show All 12 Lines