Page MenuHomePhabricator

Update mlir/CMakeLists.txt to install *.td files
ClosedPublic

Authored by kernhanda on Dec 28 2019, 2:26 AM.

Details

Summary

Currently when you build the install target, TableGen files don't get installed.

TableGen files are needed when authoring new MLIR dialects, but right now they're missing when using the pre-built binaries.

Diff Detail

Event Timeline

kernhanda created this revision.Dec 28 2019, 2:26 AM
ftynse added a subscriber: ftynse.Dec 28 2019, 2:43 AM

Could you please specify why you need them installed in the commit description?

kernhanda edited the summary of this revision. (Show Details)Dec 28 2019, 10:01 AM

Could you please specify why you need them installed in the commit description?

Done

ftynse accepted this revision.Dec 28 2019, 10:04 AM
This revision is now accepted and ready to land.Dec 28 2019, 10:04 AM

I don't have commit access, so someone else will have to submit this.

I can commit it for you. Please let me know what name and email to associate your commit with, I don't seem to find them in the description.

I can commit it for you. Please let me know what name and email to associate your commit with, I don't seem to find them in the description.

name: Kern Handa
email: kern dot handa at gmail dot com

Thanks! Let me know if there's a better way to provide commit author info in the future.

This revision was automatically updated to reflect the committed changes.

Try sending patches with arc diff, I've been told it preserves committer info. Otherwise, I pick up the address from wherever I can, e.g. the signed-off-by field or the history of commits from the same person.