Page MenuHomePhabricator

[ThinLTO] Summarize vcall_visibility metadata
ClosedPublic

Authored by tejohnson on Dec 26 2019, 9:38 AM.

Details

Summary

Second patch in series to support Safe Whole Program Devirtualization
Enablement, see RFC here:
http://lists.llvm.org/pipermail/llvm-dev/2019-December/137543.html

Summarize vcall_visibility metadata in ThinLTO global variable summary.

Depends on D71907.

Diff Detail

Event Timeline

tejohnson created this revision.Dec 26 2019, 9:38 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptDec 26 2019, 9:38 AM
evgeny777 added inline comments.Dec 27 2019, 5:49 AM
llvm/include/llvm/IR/ModuleSummaryIndex.h
807

getVCallVisibility() ?

tejohnson marked an inline comment as done.Dec 29 2019, 9:25 AM
tejohnson updated this revision to Diff 235509.Dec 29 2019, 9:26 AM

Implement suggested name change.

tejohnson updated this revision to Diff 235510.Dec 29 2019, 9:30 AM

Attempt to fix patch to not include parent revision changes

I think this has to be rebased - I see multiple failures when trying to apply

I think this has to be rebased - I see multiple failures when trying to apply

I'll rebase it today.

evgeny777 added inline comments.Tue, Jan 21, 7:54 AM
llvm/include/llvm/IR/ModuleSummaryIndex.h
762

I think using default parameter is error prone here. Can you please get rid of it and update all places of usage respectively?

tejohnson marked an inline comment as done.Tue, Jan 21, 12:51 PM

Address comment and rebase

This revision is now accepted and ready to land.Thu, Jan 23, 7:11 AM
This revision was automatically updated to reflect the committed changes.