This is an archive of the discontinued LLVM Phabricator instance.

[test][llvm-dwarfdump] Add missing checks for table dumping
ClosedPublic

Authored by jhenderson on Dec 20 2019, 5:30 AM.

Details

Summary

Some of the tables in debug_line_malformed.s were not being checked in the NONFATAL checks in debug_line_invalid.test (only the warnings coming from them were being checked). This made the test harder to follow. Additionally, a later change will change the way the errors are handled such that more of the line table will be printed. That will require checks for these tables (or something equivalent) so that the difference in behaviour can be observed. This patch adds checks for the three tables that were missing checks.

Depends on D71752.

Diff Detail

Event Timeline

jhenderson created this revision.Dec 20 2019, 5:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 20 2019, 5:30 AM
jhenderson added a comment.EditedJan 2 2020, 9:00 AM
This comment has been deleted.
MaskRay accepted this revision.Jan 2 2020, 9:58 AM
This revision is now accepted and ready to land.Jan 2 2020, 9:58 AM
This revision was automatically updated to reflect the committed changes.