This is an archive of the discontinued LLVM Phabricator instance.

Differential D71757

[test][llvm-dwarfdump] Use --implicit-check-not to simplify check
ClosedPublic

Authored by jhenderson on Dec 20 2019, 5:42 AM.

Details

Reviewers
ikudrin
JDevlieghere
dblaikie
MaskRay
probinson
Commits
rG7b4badf6f9ad: [test][llvm-dwarfdump] Use --implicit-check-not to simplify test checks
Summary

This removes the need to duplicate the LASTONLY check pattern and the last part of the NONFATAL pattern in the modified test.

Depends on D71756 and D71755.

Diff Detail

Revision Contents

Diff 236014

llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test

Show All 18 Lines
## Stop looking for the specified unit, if a fatally-bad prologue is detected. ## Stop looking for the specified unit, if a fatally-bad prologue is detected.
# RUN: llvm-dwarfdump -debug-line=0x4b %t-reserved.o 2> %t-reserved-off-last.err \ # RUN: llvm-dwarfdump -debug-line=0x4b %t-reserved.o 2> %t-reserved-off-last.err \
# RUN: | FileCheck %s --check-prefixes=NOFIRST,NOLATER # RUN: | FileCheck %s --check-prefixes=NOFIRST,NOLATER
# RUN: FileCheck %s --input-file=%t-reserved-off-last.err --check-prefix=RESERVED # RUN: FileCheck %s --input-file=%t-reserved-off-last.err --check-prefix=RESERVED
## Show that non-fatal errors do not prevent parsing the rest of the section. ## Show that non-fatal errors do not prevent parsing the rest of the section.
# RUN: llvm-mc -triple x86_64-pc-linux %S/Inputs/debug_line_malformed.s -filetype=obj -o %t-malformed.o # RUN: llvm-mc -triple x86_64-pc-linux %S/Inputs/debug_line_malformed.s -filetype=obj -o %t-malformed.o
# RUN: llvm-dwarfdump -debug-line %t-malformed.o 2> %t-malformed.err \ # RUN: llvm-dwarfdump -debug-line %t-malformed.o 2> %t-malformed.err \
# RUN: | FileCheck %s --check-prefixes=FIRST,NONFATAL # RUN: | FileCheck %s --check-prefixes=FIRST,NONFATAL,LAST --implicit-check-not='debug_line[{{.*}}]'
# RUN: FileCheck %s --input-file=%t-malformed.err --check-prefixes=ALL,OTHER # RUN: FileCheck %s --input-file=%t-malformed.err --check-prefixes=ALL,OTHER
# RUN: llvm-dwarfdump -debug-line %t-malformed.o -verbose 2> %t-malformed-verbose.err \ # RUN: llvm-dwarfdump -debug-line %t-malformed.o -verbose 2> %t-malformed-verbose.err \
# RUN: | FileCheck %s --check-prefixes=FIRST,NONFATAL # RUN: | FileCheck %s --check-prefixes=FIRST,NONFATAL,LAST --implicit-check-not='debug_line[{{.*}}]'
# RUN: FileCheck %s --input-file=%t-malformed-verbose.err --check-prefixes=ALL,OTHER # RUN: FileCheck %s --input-file=%t-malformed-verbose.err --check-prefixes=ALL,OTHER
## We should still produce warnings for malformed tables after the specified unit. ## We should still produce warnings for malformed tables after the specified unit.
# RUN: llvm-dwarfdump -debug-line=0 %t-malformed.o 2> %t-malformed-off-first.err \ # RUN: llvm-dwarfdump -debug-line=0 %t-malformed.o 2> %t-malformed-off-first.err \
# RUN: | FileCheck %s --check-prefixes=FIRST,NOLATER # RUN: | FileCheck %s --check-prefixes=FIRST,NOLATER
# RUN: FileCheck %s --input-file=%t-malformed-off-first.err --check-prefix=ALL # RUN: FileCheck %s --input-file=%t-malformed-off-first.err --check-prefix=ALL
## Don't stop looking for the later unit if non-fatal issues are found. ## Don't stop looking for the later unit if non-fatal issues are found.
# RUN: llvm-dwarfdump -debug-line=0x2af %t-malformed.o 2> %t-malformed-off-last.err \ # RUN: llvm-dwarfdump -debug-line=0x2af %t-malformed.o 2> %t-malformed-off-last.err \
# RUN: | FileCheck %s --check-prefixes=LASTONLY # RUN: | FileCheck %s --check-prefix=LAST --implicit-check-not='debug_line[{{.*}}]'
# RUN: FileCheck %s --input-file=%t-malformed-off-last.err --check-prefix=ALL # RUN: FileCheck %s --input-file=%t-malformed-off-last.err --check-prefix=ALL
# FIRST: debug_line[0x00000000] # FIRST: debug_line[0x00000000]
# FIRST: 0x000000000badbeef {{.*}} end_sequence # FIRST: 0x000000000badbeef {{.*}} end_sequence
# NOFIRST-NOT: debug_line[0x00000000] # NOFIRST-NOT: debug_line[0x00000000]
# NOFIRST-NOT: 0x000000000badbeef {{.*}} end_sequence # NOFIRST-NOT: 0x000000000badbeef {{.*}} end_sequence
# NOLATER-NOT: debug_line[{{.*}}] # NOLATER-NOT: debug_line[{{.*}}]
# NOLATER-NOT: end_sequence # NOLATER-NOT: end_sequence
▲ Show 20 Lines • Show All 82 Lines • ▼ Show 20 Lines
# NONFATAL-NOT: file_names # NONFATAL-NOT: file_names
# NONFATAL-NOT: Address # NONFATAL-NOT: Address
## Case 11: V5 invalid MD5 hash form. ## Case 11: V5 invalid MD5 hash form.
# NONFATAL: debug_line[0x0000026d] # NONFATAL: debug_line[0x0000026d]
# NONFATAL-NEXT: Line table prologue # NONFATAL-NEXT: Line table prologue
# NONFATAL-NOT: Address # NONFATAL-NOT: Address
# NONFATAL: debug_line[0x000002af] # LAST: debug_line[0x000002af]
# NONFATAL-NOT: debug_line[{{.*}}] # LAST: 0x00000000cafebabe {{.*}} end_sequence
# NONFATAL: 0x00000000cafebabe {{.*}} end_sequence
# NONFATAL-NOT: debug_line[{{.*}}]
# LASTONLY-NOT: debug_line[{{.*}}]
# LASTONLY: debug_line[0x000002af]
# LASTONLY: 0x00000000cafebabe {{.*}} end_sequence
# RESERVED: warning: parsing line table prologue at offset 0x00000048 unsupported reserved unit length found of value 0xfffffffe # RESERVED: warning: parsing line table prologue at offset 0x00000048 unsupported reserved unit length found of value 0xfffffffe
# ALL-NOT: warning: # ALL-NOT: warning:
# ALL: warning: parsing line table prologue at offset 0x00000048 found unsupported version 0x00 # ALL: warning: parsing line table prologue at offset 0x00000048 found unsupported version 0x00
# ALL-NEXT: warning: parsing line table prologue at offset 0x0000004e found unsupported version 0x01 # ALL-NEXT: warning: parsing line table prologue at offset 0x0000004e found unsupported version 0x01
# ALL-NEXT: warning: parsing line table prologue at 0x00000054 found an invalid directory or file table description at 0x00000073 # ALL-NEXT: warning: parsing line table prologue at 0x00000054 found an invalid directory or file table description at 0x00000073
# ALL-NEXT: warning: failed to parse entry content descriptions because no path was found # ALL-NEXT: warning: failed to parse entry content descriptions because no path was found
Show All 14 Lines