This is an archive of the discontinued LLVM Phabricator instance.

Differential D71752

[test][llvm-dwarfdump][NFC] Improve test readability
ClosedPublic

Authored by jhenderson on Dec 20 2019, 5:24 AM.

Details

Reviewers
JDevlieghere
ikudrin
MaskRay
dblaikie
probinson
Commits
rG0ae9e952f73f: [test][llvm-dwarfdump][NFC] Improve test readability
Summary

This patch adds and improves comments in the debug_line_invalid.test and its associated input file so that it is easier to follow. It uses '##' to make comments stand out from lit and FileCheck commands.

It also reflows some commands so that the lines are not so long and are easier to read and fixes some copy/paste errors.

This patch is the first in a series as an alternative to D71702.

Diff Detail

Event Timeline

jhenderson created this revision.Dec 20 2019, 5:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 20 2019, 5:24 AM
jhenderson added a child revision: D71753: [test][llvm-dwarfdump] Add missing checks for table dumping.Dec 20 2019, 5:30 AM
jhenderson mentioned this in D71702: [DebugInfo] Relax some checking in the debug line parser.Dec 20 2019, 5:43 AM
JDevlieghere accepted this revision.Dec 20 2019, 3:57 PM
This revision is now accepted and ready to land.Dec 20 2019, 3:57 PM
Closed by commit rG0ae9e952f73f: [test][llvm-dwarfdump][NFC] Improve test readability (authored by jhenderson). · Explain WhyJan 2 2020, 9:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-dwarfdump/
X86/
Inputs/
41 lines
65 lines

Diff 234865

llvm/test/tools/llvm-dwarfdump/X86/Inputs/debug_line_malformed.s

.section .debug_line,"",@progbits .section .debug_line,"",@progbits
# Leading good section # Leading good section.
.long .Lunit1_end - .Lunit1_start # Length of Unit (DWARF-32 format) .long .Lunit1_end - .Lunit1_start # Length of Unit (DWARF-32 format)
.Lunit1_start: .Lunit1_start:
.short 4 # DWARF version number .short 4 # DWARF version number
.long .Lprologue1_end-.Lprologue1_start # Length of Prologue .long .Lprologue1_end-.Lprologue1_start # Length of Prologue
.Lprologue1_start: .Lprologue1_start:
.byte 1 # Minimum Instruction Length .byte 1 # Minimum Instruction Length
.byte 1 # Maximum Operations per Instruction .byte 1 # Maximum Operations per Instruction
.byte 1 # Default is_stmt .byte 1 # Default is_stmt
Show All 10 Lines
.byte 1, 0, 0 .byte 1, 0, 0
.byte 0 .byte 0
.Lprologue1_end: .Lprologue1_end:
.byte 0, 9, 2 # DW_LNE_set_address .byte 0, 9, 2 # DW_LNE_set_address
.quad 0x0badbeef .quad 0x0badbeef
.byte 0, 1, 1 # DW_LNE_end_sequence .byte 0, 1, 1 # DW_LNE_end_sequence
.Lunit1_end: .Lunit1_end:
# version 0 # Version 0.
.long .Lunit_v0_end - .Lunit_v0_start # unit length .long .Lunit_v0_end - .Lunit_v0_start # unit length
.Lunit_v0_start: .Lunit_v0_start:
.short 0 # version .short 0 # version
.Lunit_v0_end: .Lunit_v0_end:
# version 1 # Version 1.
.long .Lunit_v1_end - .Lunit_v1_start # unit length .long .Lunit_v1_end - .Lunit_v1_start # unit length
.Lunit_v1_start: .Lunit_v1_start:
.short 1 # version .short 1 # version
.Lunit_v1_end: .Lunit_v1_end:
# version 5 malformed line/include table # Version 5 malformed line/include table.
.long .Lunit_v5_end - .Lunit_v5_start # unit length .long .Lunit_v5_end - .Lunit_v5_start # unit length
.Lunit_v5_start: .Lunit_v5_start:
.short 5 # version .short 5 # version
.byte 8 # address size .byte 8 # address size
.byte 8 # segment selector .byte 8 # segment selector
.long .Lprologue_v5_end-.Lprologue_v5_start # Length of Prologue .long .Lprologue_v5_end-.Lprologue_v5_start # Length of Prologue
.Lprologue_v5_start: .Lprologue_v5_start:
.byte 1 # Minimum Instruction Length .byte 1 # Minimum Instruction Length
.byte 1 # Maximum Operations per Instruction .byte 1 # Maximum Operations per Instruction
.byte 1 # Default is_stmt .byte 1 # Default is_stmt
.byte -5 # Line Base .byte -5 # Line Base
.byte 14 # Line Range .byte 14 # Line Range
.byte 13 # Opcode Base .byte 13 # Opcode Base
.byte 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1 # Standard Opcode Lengths .byte 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1 # Standard Opcode Lengths
.byte 0 # directory table (invalid) .byte 0 # directory table (invalid as no path component)
.Lprologue_v5_end: .Lprologue_v5_end:
.Lunit_v5_end: .Lunit_v5_end:
# Short prologue # Short prologue.
.long .Lunit_short_prologue_end - .Lunit_short_prologue_start # unit length .long .Lunit_short_prologue_end - .Lunit_short_prologue_start # unit length
.Lunit_short_prologue_start: .Lunit_short_prologue_start:
.short 4 # version .short 4 # version
.long .Lprologue_short_prologue_end-.Lprologue_short_prologue_start - 2 # Length of Prologue .long .Lprologue_short_prologue_end-.Lprologue_short_prologue_start - 2 # Length of Prologue
.Lprologue_short_prologue_start: .Lprologue_short_prologue_start:
.byte 1 # Minimum Instruction Length .byte 1 # Minimum Instruction Length
.byte 1 # Maximum Operations per Instruction .byte 1 # Maximum Operations per Instruction
.byte 1 # Default is_stmt .byte 1 # Default is_stmt
.byte -5 # Line Base .byte -5 # Line Base
.byte 14 # Line Range .byte 14 # Line Range
.byte 13 # Opcode Base .byte 13 # Opcode Base
.byte 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1 # Standard Opcode Lengths .byte 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1 # Standard Opcode Lengths
.asciz "dir1" # Include table .asciz "dir1" # Include table
.asciz "dir2" .asciz "dir2"
.byte 0 .byte 0
.asciz "file1" # File table .asciz "file1" # File table
.byte 0, 0, 0 .byte 0, 0, 0
.asciz "file2" .asciz "file2"
.byte 1, 0, 0 .byte 1, 0, 0
.byte 0 .byte 0
.Lprologue_short_prologue_end: .Lprologue_short_prologue_end:
.Lunit_short_prologue_end: .Lunit_short_prologue_end:
# Over-long prologue # Over-long prologue.
.long .Lunit_long_prologue_end - .Lunit_long_prologue_start # unit length .long .Lunit_long_prologue_end - .Lunit_long_prologue_start # unit length
.Lunit_long_prologue_start: .Lunit_long_prologue_start:
.short 4 # version .short 4 # version
.long .Lprologue_long_prologue_end-.Lprologue_long_prologue_start + 1 # Length of Prologue .long .Lprologue_long_prologue_end-.Lprologue_long_prologue_start + 1 # Length of Prologue
.Lprologue_long_prologue_start: .Lprologue_long_prologue_start:
.byte 1 # Minimum Instruction Length .byte 1 # Minimum Instruction Length
.byte 1 # Maximum Operations per Instruction .byte 1 # Maximum Operations per Instruction
.byte 1 # Default is_stmt .byte 1 # Default is_stmt
.byte -5 # Line Base .byte -5 # Line Base
.byte 14 # Line Range .byte 14 # Line Range
.byte 13 # Opcode Base .byte 13 # Opcode Base
.byte 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1 # Standard Opcode Lengths .byte 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1 # Standard Opcode Lengths
.asciz "dir1" # Include table .asciz "dir1" # Include table
.asciz "dir2" .asciz "dir2"
.byte 0 .byte 0
.asciz "file1" # File table .asciz "file1" # File table
.byte 0, 0, 0 .byte 0, 0, 0
.asciz "file2" .asciz "file2"
.byte 1, 0, 0 .byte 1, 0, 0
.byte 0 .byte 0
.Lprologue_long_prologue_end: .Lprologue_long_prologue_end:
.Lunit_long_prologue_end: .Lunit_long_prologue_end:
# Over-long extended opcode # Over-long extended opcode.
.long .Lunit_long_opcode_end - .Lunit_long_opcode_start # unit length .long .Lunit_long_opcode_end - .Lunit_long_opcode_start # unit length
.Lunit_long_opcode_start: .Lunit_long_opcode_start:
.short 4 # version .short 4 # version
.long .Lprologue_long_opcode_end-.Lprologue_long_opcode_start # Length of Prologue .long .Lprologue_long_opcode_end-.Lprologue_long_opcode_start # Length of Prologue
.Lprologue_long_opcode_start: .Lprologue_long_opcode_start:
.byte 1 # Minimum Instruction Length .byte 1 # Minimum Instruction Length
.byte 1 # Maximum Operations per Instruction .byte 1 # Maximum Operations per Instruction
.byte 1 # Default is_stmt .byte 1 # Default is_stmt
.byte -5 # Line Base .byte -5 # Line Base
.byte 14 # Line Range .byte 14 # Line Range
.byte 13 # Opcode Base .byte 13 # Opcode Base
.byte 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1 # Standard Opcode Lengths .byte 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1 # Standard Opcode Lengths
.asciz "dir1" # Include table .asciz "dir1" # Include table
.asciz "dir2" .asciz "dir2"
.byte 0 .byte 0
.asciz "file1" # File table .asciz "file1" # File table
.byte 0, 0, 0 .byte 0, 0, 0
.asciz "file2" .asciz "file2"
.byte 1, 0, 0 .byte 1, 0, 0
.byte 0 .byte 0
.Lprologue_long_opcode_end: .Lprologue_long_opcode_end:
.byte 0, 9, 2 # DW_LNE_set_address .byte 0, 9, 2 # DW_LNE_set_address
.quad 0xabbadaba .quad 0xabbadaba
.byte 0, 2, 1 # DW_LNE_end_sequence (wrong length) .byte 0, 2, 1 # DW_LNE_end_sequence (too long)
.byte 0, 9, 2 # DW_LNE_set_address .byte 0, 9, 2 # DW_LNE_set_address
.quad 0xbabb1e45 .quad 0xbabb1e45
.byte 0, 1, 1 # DW_LNE_end_sequence (wrong length) .byte 0, 1, 1 # DW_LNE_end_sequence
.Lunit_long_opcode_end: .Lunit_long_opcode_end:
# No end of sequence # No end of sequence.
.long .Lunit_no_eos_end - .Lunit_no_eos_start # unit length .long .Lunit_no_eos_end - .Lunit_no_eos_start # unit length
.Lunit_no_eos_start: .Lunit_no_eos_start:
.short 4 # version .short 4 # version
.long .Lprologue_no_eos_end-.Lprologue_no_eos_start # Length of Prologue .long .Lprologue_no_eos_end-.Lprologue_no_eos_start # Length of Prologue
.Lprologue_no_eos_start: .Lprologue_no_eos_start:
.byte 1 # Minimum Instruction Length .byte 1 # Minimum Instruction Length
.byte 1 # Maximum Operations per Instruction .byte 1 # Maximum Operations per Instruction
.byte 1 # Default is_stmt .byte 1 # Default is_stmt
Show All 10 Lines
.byte 1, 0, 0 .byte 1, 0, 0
.byte 0 .byte 0
.Lprologue_no_eos_end: .Lprologue_no_eos_end:
.byte 0, 9, 2 # DW_LNE_set_address .byte 0, 9, 2 # DW_LNE_set_address
.quad 0xdeadfade .quad 0xdeadfade
.byte 1 # DW_LNS_copy .byte 1 # DW_LNS_copy
.Lunit_no_eos_end: .Lunit_no_eos_end:
# Invalid prologue length # V5 very short prologue length.
.long .Linvalid_description_end0-.Linvalid_description_start0 # Length of Unit .long .Linvalid_description_end0-.Linvalid_description_start0 # Length of Unit
.Linvalid_description_start0: .Linvalid_description_start0:
.short 5 # DWARF version number .short 5 # DWARF version number
.byte 8 # Address Size .byte 8 # Address Size
.byte 0 # Segment Selector Size .byte 0 # Segment Selector Size
.long 15 # Length of Prologue (invalid) .long 15 # Length of Prologue (invalid)
.Linvalid_description_params0: .Linvalid_description_params0:
.byte 1 # Minimum Instruction Length .byte 1 # Minimum Instruction Length
Show All 22 Lines
.byte 0 .byte 0
.Linvalid_description_header_end0: .Linvalid_description_header_end0:
.byte 0,2,4,1 # DW_LNE_set_discriminator 1 .byte 0,2,4,1 # DW_LNE_set_discriminator 1
.byte 1 # DW_LNS_copy .byte 1 # DW_LNS_copy
.byte 33 # address += 1, line += 1 .byte 33 # address += 1, line += 1
.byte 0,1,1 # DW_LNE_end_sequence .byte 0,1,1 # DW_LNE_end_sequence
.Linvalid_description_end0: .Linvalid_description_end0:
# Invalid file entry # V5 prologue ends during file table.
.long .Linvalid_file_end0-.Linvalid_file_start0 # Length of Unit .long .Linvalid_file_end0-.Linvalid_file_start0 # Length of Unit
.Linvalid_file_start0: .Linvalid_file_start0:
.short 5 # DWARF version number .short 5 # DWARF version number
.byte 8 # Address Size .byte 8 # Address Size
.byte 0 # Segment Selector Size .byte 0 # Segment Selector Size
.long .Linvalid_file_header_end0-.Linvalid_file_params0-7 # Length of Prologue (invalid) .long .Linvalid_file_header_end0-.Linvalid_file_params0-7 # Length of Prologue (invalid)
.Linvalid_file_params0: .Linvalid_file_params0:
.byte 1 # Minimum Instruction Length .byte 1 # Minimum Instruction Length
Show All 22 Lines
.byte 0 .byte 0
.Linvalid_file_header_end0: .Linvalid_file_header_end0:
.byte 0,2,4,1 # DW_LNE_set_discriminator 1 .byte 0,2,4,1 # DW_LNE_set_discriminator 1
.byte 1 # DW_LNS_copy .byte 1 # DW_LNS_copy
.byte 33 # address += 1, line += 1 .byte 33 # address += 1, line += 1
.byte 0,1,1 # DW_LNE_end_sequence .byte 0,1,1 # DW_LNE_end_sequence
.Linvalid_file_end0: .Linvalid_file_end0:
# Invalid directory entry # V5 prologue ends during directory table.
.long .Linvalid_dir_end0-.Linvalid_dir_start0 # Length of Unit .long .Linvalid_dir_end0-.Linvalid_dir_start0 # Length of Unit
.Linvalid_dir_start0: .Linvalid_dir_start0:
.short 5 # DWARF version number .short 5 # DWARF version number
.byte 8 # Address Size .byte 8 # Address Size
.byte 0 # Segment Selector Size .byte 0 # Segment Selector Size
.long .Linvalid_dir_header_end0-.Linvalid_dir_params0-16 # Length of Prologue (invalid) .long .Linvalid_dir_header_end0-.Linvalid_dir_params0-16 # Length of Prologue (invalid)
.Linvalid_dir_params0: .Linvalid_dir_params0:
.byte 1 # Minimum Instruction Length .byte 1 # Minimum Instruction Length
Show All 22 Lines
.byte 0 .byte 0
.Linvalid_dir_header_end0: .Linvalid_dir_header_end0:
.byte 0,2,4,1 # DW_LNE_set_discriminator 1 .byte 0,2,4,1 # DW_LNE_set_discriminator 1
.byte 1 # DW_LNS_copy .byte 1 # DW_LNS_copy
.byte 33 # address += 1, line += 1 .byte 33 # address += 1, line += 1
.byte 0,1,1 # DW_LNE_end_sequence .byte 0,1,1 # DW_LNE_end_sequence
.Linvalid_dir_end0: .Linvalid_dir_end0:
# Invalid MD5 hash # Invalid MD5 hash.
.long .Linvalid_md5_end0-.Linvalid_md5_start0 # Length of Unit .long .Linvalid_md5_end0-.Linvalid_md5_start0 # Length of Unit
.Linvalid_md5_start0: .Linvalid_md5_start0:
.short 5 # DWARF version number .short 5 # DWARF version number
.byte 8 # Address Size .byte 8 # Address Size
.byte 0 # Segment Selector Size .byte 0 # Segment Selector Size
.long .Linvalid_md5_header_end0-.Linvalid_md5_params0 # Length of Prologue (invalid) .long .Linvalid_md5_header_end0-.Linvalid_md5_params0 # Length of Prologue
.Linvalid_md5_params0: .Linvalid_md5_params0:
.byte 1 # Minimum Instruction Length .byte 1 # Minimum Instruction Length
.byte 1 # Maximum Operations per Instruction .byte 1 # Maximum Operations per Instruction
.byte 1 # Default is_stmt .byte 1 # Default is_stmt
.byte -5 # Line Base .byte -5 # Line Base
.byte 14 # Line Range .byte 14 # Line Range
.byte 13 # Opcode Base .byte 13 # Opcode Base
.byte 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1 # Standard Opcode Lengths .byte 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1 # Standard Opcode Lengths
# Directory table format # Directory table format
.byte 1 # One element per directory entry .byte 1 # One element per directory entry
.byte 1 # DW_LNCT_path .byte 1 # DW_LNCT_path
.byte 0x08 # DW_FORM_string .byte 0x08 # DW_FORM_string
# Directory table entries # Directory table entries
.byte 1 # 1 directory .byte 1 # 1 directory
.asciz "/tmp" .asciz "/tmp"
# File table format # File table format
.byte 3 # 2 elements per file entry .byte 3 # 3 elements per file entry
.byte 1 # DW_LNCT_path .byte 1 # DW_LNCT_path
.byte 0x08 # DW_FORM_string .byte 0x08 # DW_FORM_string
.byte 2 # DW_LNCT_directory_index .byte 2 # DW_LNCT_directory_index
.byte 0x0b # DW_FORM_data1 .byte 0x0b # DW_FORM_data1
.byte 5 # DW_LNCT_MD5 .byte 5 # DW_LNCT_MD5
.byte 0x09 # DW_FORM_data1 .byte 0x09 # DW_FORM_data1
# File table entries # File table entries
.byte 1 # 1 file .byte 1 # 1 file
.asciz "a.c" .asciz "a.c"
.byte 0 .byte 0
.Linvalid_md5_header_end0: .Linvalid_md5_header_end0:
.byte 0,2,4,1 # DW_LNE_set_discriminator 1 .byte 0,2,4,1 # DW_LNE_set_discriminator 1
.byte 1 # DW_LNS_copy .byte 1 # DW_LNS_copy
.byte 33 # address += 1, line += 1 .byte 33 # address += 1, line += 1
.byte 0,1,1 # DW_LNE_end_sequence .byte 0,1,1 # DW_LNE_end_sequence
.Linvalid_md5_end0: .Linvalid_md5_end0:
# Trailing good section # Trailing good section.
.long .Lunit_good_end - .Lunit_good_start # Length of Unit (DWARF-32 format) .long .Lunit_good_end - .Lunit_good_start # Length of Unit (DWARF-32 format)
.Lunit_good_start: .Lunit_good_start:
.short 4 # DWARF version number .short 4 # DWARF version number
.long .Lprologue_good_end-.Lprologue_good_start # Length of Prologue .long .Lprologue_good_end-.Lprologue_good_start # Length of Prologue
.Lprologue_good_start: .Lprologue_good_start:
.byte 1 # Minimum Instruction Length .byte 1 # Minimum Instruction Length
.byte 1 # Maximum Operations per Instruction .byte 1 # Maximum Operations per Instruction
.byte 1 # Default is_stmt .byte 1 # Default is_stmt
Show All 9 Lines
.asciz "file2" .asciz "file2"
.byte 1, 0, 0 .byte 1, 0, 0
.byte 0 .byte 0
.Lprologue_good_end: .Lprologue_good_end:
.byte 0, 9, 2 # DW_LNE_set_address .byte 0, 9, 2 # DW_LNE_set_address
.quad 0xcafebabe .quad 0xcafebabe
.byte 0, 1, 1 # DW_LNE_end_sequence .byte 0, 1, 1 # DW_LNE_end_sequence
.Lunit_good_end: .Lunit_good_end:

llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test

# Test the different error cases in the debug line parsing and how they prevent ## Test the different error cases in the debug line parsing and how they prevent
# or don't prevent further dumping of section contents. ## or don't prevent further dumping of section contents.
## Show that a bad length stops parsing of the section.
# RUN: llvm-mc -triple x86_64-pc-linux %S/Inputs/debug_line_reserved_length.s -filetype=obj -o %t-reserved.o # RUN: llvm-mc -triple x86_64-pc-linux %S/Inputs/debug_line_reserved_length.s -filetype=obj -o %t-reserved.o
# RUN: llvm-dwarfdump -debug-line %t-reserved.o 2> %t-reserved.err | FileCheck %s --check-prefixes=FIRST,FATAL # RUN: llvm-dwarfdump -debug-line %t-reserved.o 2> %t-reserved.err \
# RUN: | FileCheck %s --check-prefixes=FIRST,FATAL
# RUN: FileCheck %s --input-file=%t-reserved.err --check-prefix=RESERVED # RUN: FileCheck %s --input-file=%t-reserved.err --check-prefix=RESERVED
# RUN: llvm-dwarfdump -debug-line %t-reserved.o -verbose 2> %t-reserved-verbose.err | FileCheck %s --check-prefixes=FIRST,FATAL # RUN: llvm-dwarfdump -debug-line %t-reserved.o -verbose 2> %t-reserved-verbose.err \
# RUN: | FileCheck %s --check-prefixes=FIRST,FATAL
# RUN: FileCheck %s --input-file=%t-reserved-verbose.err --check-prefix=RESERVED # RUN: FileCheck %s --input-file=%t-reserved-verbose.err --check-prefix=RESERVED
# We should still produce warnings for malformed tables after the specified unit. ## We only produce warnings for malformed tables after the specified unit if
# RUN: llvm-dwarfdump -debug-line=0 %t-reserved.o 2> %t-reserved-off-first.err | FileCheck %s --check-prefixes=FIRST,NOLATER ## parsing can continue.
# RUN: llvm-dwarfdump -debug-line=0 %t-reserved.o 2> %t-reserved-off-first.err \
# RUN: | FileCheck %s --check-prefixes=FIRST,NOLATER
# RUN: FileCheck %s --input-file=%t-reserved-off-first.err --check-prefix=RESERVED # RUN: FileCheck %s --input-file=%t-reserved-off-first.err --check-prefix=RESERVED
# Stop looking for the specified unit, if a fatally-bad prologue is detected. ## Stop looking for the specified unit, if a fatally-bad prologue is detected.
# RUN: llvm-dwarfdump -debug-line=0x4b %t-reserved.o 2> %t-reserved-off-last.err | FileCheck %s --check-prefixes=NOFIRST,NOLATER # RUN: llvm-dwarfdump -debug-line=0x4b %t-reserved.o 2> %t-reserved-off-last.err \
# RUN: | FileCheck %s --check-prefixes=NOFIRST,NOLATER
# RUN: FileCheck %s --input-file=%t-reserved-off-last.err --check-prefix=RESERVED # RUN: FileCheck %s --input-file=%t-reserved-off-last.err --check-prefix=RESERVED
## Show that non-fatal errors do not prevent parsing the rest of the section.
# RUN: llvm-mc -triple x86_64-pc-linux %S/Inputs/debug_line_malformed.s -filetype=obj -o %t-malformed.o # RUN: llvm-mc -triple x86_64-pc-linux %S/Inputs/debug_line_malformed.s -filetype=obj -o %t-malformed.o
# RUN: llvm-dwarfdump -debug-line %t-malformed.o 2> %t-malformed.err | FileCheck %s --check-prefixes=FIRST,NONFATAL # RUN: llvm-dwarfdump -debug-line %t-malformed.o 2> %t-malformed.err \
# RUN: | FileCheck %s --check-prefixes=FIRST,NONFATAL
# RUN: FileCheck %s --input-file=%t-malformed.err --check-prefixes=ALL,OTHER # RUN: FileCheck %s --input-file=%t-malformed.err --check-prefixes=ALL,OTHER
# RUN: llvm-dwarfdump -debug-line %t-malformed.o -verbose 2> %t-malformed-verbose.err | FileCheck %s --check-prefixes=FIRST,NONFATAL # RUN: llvm-dwarfdump -debug-line %t-malformed.o -verbose 2> %t-malformed-verbose.err \
# RUN: | FileCheck %s --check-prefixes=FIRST,NONFATAL
# RUN: FileCheck %s --input-file=%t-malformed-verbose.err --check-prefixes=ALL,OTHER # RUN: FileCheck %s --input-file=%t-malformed-verbose.err --check-prefixes=ALL,OTHER
# RUN: llvm-dwarfdump -debug-line=0 %t-malformed.o 2> %t-malformed-off-first.err | FileCheck %s --check-prefixes=FIRST,NOLATER ## We should still produce warnings for malformed tables after the specified unit.
# RUN: llvm-dwarfdump -debug-line=0 %t-malformed.o 2> %t-malformed-off-first.err \
# RUN: | FileCheck %s --check-prefixes=FIRST,NOLATER
# RUN: FileCheck %s --input-file=%t-malformed-off-first.err --check-prefix=ALL # RUN: FileCheck %s --input-file=%t-malformed-off-first.err --check-prefix=ALL
# Don't stop looking for the later unit if non-fatal issues are found. ## Don't stop looking for the later unit if non-fatal issues are found.
# RUN: llvm-dwarfdump -debug-line=0x271 %t-malformed.o 2> %t-malformed-off-last.err | FileCheck %s --check-prefixes=LASTONLY # RUN: llvm-dwarfdump -debug-line=0x271 %t-malformed.o 2> %t-malformed-off-last.err \
# RUN: | FileCheck %s --check-prefixes=LASTONLY
# RUN: FileCheck %s --input-file=%t-malformed-off-last.err --check-prefix=ALL # RUN: FileCheck %s --input-file=%t-malformed-off-last.err --check-prefix=ALL
# FIRST: debug_line[0x00000000] # FIRST: debug_line[0x00000000]
# FIRST: 0x000000000badbeef {{.*}} end_sequence # FIRST: 0x000000000badbeef {{.*}} end_sequence
# NOFIRST-NOT: debug_line[0x00000000] # NOFIRST-NOT: debug_line[0x00000000]
# NOFIRST-NOT: 0x000000000badbeef {{.*}} end_sequence # NOFIRST-NOT: 0x000000000badbeef {{.*}} end_sequence
# NOLATER-NOT: debug_line[{{.*}}] # NOLATER-NOT: debug_line[{{.*}}]
# NOLATER-NOT: end_sequence # NOLATER-NOT: end_sequence
# For fatal issues, the following table(s) should not be dumped. ## For fatal issues, the following table(s) should not be dumped.
# FATAL: debug_line[0x00000048] # FATAL: debug_line[0x00000048]
# FATAL-NEXT: Line table prologue # FATAL-NEXT: Line table prologue
# FATAL-NEXT: total_length: 0xfffffffe # FATAL-NEXT: total_length: 0xfffffffe
# FATAL-NOT: debug_line # FATAL-NOT: debug_line
# For non-fatal prologue issues, the table prologue should be dumped, and any subsequent tables should also be. ## For non-fatal prologue issues, the table prologue should be dumped, and any
## subsequent tables should also be.
## Case 1: Version 0 table.
# NONFATAL: debug_line[0x00000048] # NONFATAL: debug_line[0x00000048]
# NONFATAL-NEXT: Line table prologue # NONFATAL-NEXT: Line table prologue
# NONFATAL-NOT: Address # NONFATAL-NOT: Address
## Case 2: Version 1 table.
# NONFATAL: debug_line[0x0000004e] # NONFATAL: debug_line[0x0000004e]
# NONFATAL-NEXT: Line table prologue # NONFATAL-NEXT: Line table prologue
# NONFATAL-NOT: Address # NONFATAL-NOT: Address
## Case 3: Malformed directory format with no path component.
# NONFATAL: debug_line[0x00000054] # NONFATAL: debug_line[0x00000054]
# NONFATAL-NEXT: Line table prologue # NONFATAL-NEXT: Line table prologue
# NONFATAL-NOT: Address # NONFATAL-NOT: Address
## Case 4: Prologue with length shorter than parsed.
# NONFATAL: debug_line[0x00000073] # NONFATAL: debug_line[0x00000073]
# NONFATAL-NEXT: Line table prologue # NONFATAL-NEXT: Line table prologue
# NONFATAL-NOT: Address # NONFATAL-NOT: Address
## Case 5: Prologue with length longer than parsed.
# NONFATAL: debug_line[0x000000ad] # NONFATAL: debug_line[0x000000ad]
# NONFATAL-NEXT: Line table prologue # NONFATAL-NEXT: Line table prologue
# NONFATAL-NOT: Address # NONFATAL-NOT: Address
## Case 6: Extended opcode with incorrect length versus expected.
# NONFATAL: debug_line[0x000000e7] # NONFATAL: debug_line[0x000000e7]
# Dumping prints the line table prologue and any valid operations up to the point causing the problem. ## Dumping prints the line table prologue and any valid operations up to the
## point causing the problem.
# NONFATAL-NEXT: Line table prologue # NONFATAL-NEXT: Line table prologue
# NONFATAL: 0x00000000abbadaba {{.*}} end_sequence # NONFATAL: 0x00000000abbadaba {{.*}} end_sequence
# NONFATAL-NOT: is_stmt # NONFATAL-NOT: is_stmt
# For minor issues, we can dump the table. ## For minor issues, we can dump the whole table.
## Case 7: No end of sequence.
# NONFATAL: debug_line[0x0000013d] # NONFATAL: debug_line[0x0000013d]
# NONFATAL-NEXT: Line table prologue # NONFATAL-NEXT: Line table prologue
# NONFATAL-NOT: debug_line[{{.*}}] # NONFATAL-NOT: debug_line[{{.*}}]
# NONFATAL: 0x00000000deadfade {{.*}} # NONFATAL: 0x00000000deadfade {{.*}}
## Case 8: Very short prologue length for V5 (ends during parameters).
# NONFATAL: debug_line[0x00000183] # NONFATAL: debug_line[0x00000183]
# NONFATAL-NEXT: Line table prologue # NONFATAL-NEXT: Line table prologue
## TODO: Add checks here for remaining tables.
# NONFATAL: debug_line[0x00000271] # NONFATAL: debug_line[0x00000271]
# NONFATAL-NOT: debug_line[{{.*}}] # NONFATAL-NOT: debug_line[{{.*}}]
# NONFATAL: 0x00000000cafebabe {{.*}} end_sequence # NONFATAL: 0x00000000cafebabe {{.*}} end_sequence
# NONFATAL-NOT: debug_line[{{.*}}] # NONFATAL-NOT: debug_line[{{.*}}]
# LASTONLY-NOT: debug_line[{{.*}}] # LASTONLY-NOT: debug_line[{{.*}}]
# LASTONLY: debug_line[0x00000271] # LASTONLY: debug_line[0x00000271]
# LASTONLY: 0x00000000cafebabe {{.*}} end_sequence # LASTONLY: 0x00000000cafebabe {{.*}} end_sequence
Show All 25 Lines