This is an archive of the discontinued LLVM Phabricator instance.

[CommandLine] Add template instantiations of cl::parser for long and long long.
ClosedPublic

Authored by rriddle on Dec 19 2019, 2:52 PM.

Details

Summary

This allows for cl::opt<int64_t> on LP64 platforms.

Diff Detail

Event Timeline

rriddle created this revision.Dec 19 2019, 2:52 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 19 2019, 2:52 PM
MaskRay accepted this revision.Dec 19 2019, 3:02 PM
This revision is now accepted and ready to land.Dec 19 2019, 3:02 PM

Could someone please commit this for me? I really appreciate it.

This revision was automatically updated to reflect the committed changes.
RVP added a subscriber: RVP.Nov 2 2022, 4:54 PM
RVP added inline comments.
llvm/include/llvm/Support/CommandLine.h
1041

Why is this declared as final. None of the other parsers are final. The CommandLine documentation for writing custom parsers shows that users may extend parser<unsigned>. So why can't they extend parser<long>?

Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2022, 4:54 PM