This is an archive of the discontinued LLVM Phabricator instance.

[perf-training] Change profile file pattern string to use %4m instead of %p
ClosedPublic

Authored by xinxinw1 on Dec 16 2019, 5:30 PM.

Details

Summary

With %p, each test file that we're using to generate profile data will make its own profraw file which is around 60 MB in size. If we have a lot of test files, that quickly uses a lot of space. Use %4m instead to share the profraw files used to store the profile data. We use 4 here based on the default value in https://reviews.llvm.org/source/llvm-github/browse/master/llvm/CMakeLists.txt$604

Diff Detail

Event Timeline

xinxinw1 created this revision.Dec 16 2019, 5:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 16 2019, 5:30 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
xiaobai added a subscriber: vsk.

Adding @vsk since he added the code that you're referencing in your summary.

vsk accepted this revision.Dec 17 2019, 10:54 AM

Lgtm.

Separately, if you have the bandwidth to test out the new '%c%m' mode (https://clang.llvm.org/docs/SourceBasedCodeCoverage.html#running-the-instrumented-program / https://reviews.llvm.org/D68351), I'd appreciate any feedback about it. It should use ~4x less space.

This revision is now accepted and ready to land.Dec 17 2019, 10:54 AM

@vsk Thanks! The %c mode looks pretty cool but yeah, I don't really have the bandwidth to test it right now

This revision was automatically updated to reflect the committed changes.