Switch to using the denormal-fp-math/denormal-fp-math-f32
attributes.
Details
Diff Detail
Event Timeline
This is a frontend decision. clang emits the attribute based on the subtarget preference
This is also how it always worked. The backend uniformly treated denormals as off by default
Would it be possible to do this patch in two steps:
- First step: Add the parsing of the new function attribute, but keep the subtarget feature.
- Second step: Remove the subtarget feature.
This would make the upgrade process easier for out-of-tree users (Mesa, LLPC).
Apart from that this seems like a good change to me.
Where it already does. This doesn’t change. It just changes what clang produces for the denormal flushing flag/subtarget default
That is basically how it’s split. Once the form of the attributes is finalized, frontends can start emitting the new form and we just won’t look it it until this patch
Once the form of the attributes is finalized, frontends can start emitting the new form and we just won’t look it it until this patch
Okay, that makes sense.