Page MenuHomePhabricator

[FormatManager] Add a unittest for GetCandidateLanguages()
ClosedPublic

Authored by davide on Dec 10 2019, 1:39 PM.

Diff Detail

Event Timeline

davide created this revision.Dec 10 2019, 1:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 10 2019, 1:39 PM
Herald added a subscriber: mgorny. · View Herald Transcript
JDevlieghere accepted this revision.Dec 10 2019, 1:42 PM
This revision is now accepted and ready to land.Dec 10 2019, 1:42 PM
This revision was automatically updated to reflect the committed changes.
labath added a subscriber: labath.Dec 11 2019, 1:59 AM
labath added inline comments.
lldb/unittests/DataFormatter/FormatManagerTests.cpp
9–24

This is a pretty long list of includes for such a simple test. Are you sure all of them are needed?

teemperor added inline comments.Dec 11 2019, 2:34 AM
lldb/unittests/DataFormatter/FormatManagerTests.cpp
9–24