Page MenuHomePhabricator

llc: Change behavior of -mattr with existing attribute
ClosedPublic

Authored by arsenm on Dec 10 2019, 4:43 AM.

Details

Summary

Append this to the existing target-features attribute on the function.

Some flags ignore existing attributes, and some overwrite them. Move
towards consistently respecting existing attributes if present. Since
target features act as a state machine on their own, append to the
function attribute. The backend default added feature list, function
attributes, and -mattr will all be appended together, and the later
features can individually toggle the earlier settings.

Diff Detail