Page MenuHomePhabricator

[DWARF5] Start emitting DW_AT_dwo_name when -gdwarf-5 is specified.
ClosedPublic

Authored by SouraVX on Dec 9 2019, 12:54 AM.

Diff Detail

Event Timeline

SouraVX created this revision.Dec 9 2019, 12:54 AM

Build result: pass - 60606 tests passed, 0 failed and 726 were skipped.

Log files: console-log.txt, CMakeCache.txt

Address the inline comments and LGTM.

llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
859

This should be moved down under the 'if' so it's in the same scope as the only use.

1104

This should be moved down under the 'if' so it's in the same scope as the only uses.

SouraVX updated this revision to Diff 232896.Dec 9 2019, 10:41 AM

Thank you Paul, for reviewing this. I've addressed your comments in this revision.

probinson accepted this revision.Dec 9 2019, 11:11 AM

Yep LGTM.

This revision is now accepted and ready to land.Dec 9 2019, 11:11 AM
This revision was automatically updated to reflect the committed changes.