This is an archive of the discontinued LLVM Phabricator instance.

[libomptarget][nfc] Move three more files to common
ClosedPublic

Authored by JonChesterfield on Dec 5 2019, 6:06 PM.

Details

Summary

[libomptarget][nfc] Move three more files to common

Diff Detail

Event Timeline

JonChesterfield created this revision.Dec 5 2019, 6:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 5 2019, 6:06 PM

After this patch common/ actually contains more SLOC than nvptx/. Parts of libcall.cu and data_sharing.cu are architecture agnostic, reduction.cu probably needs a bespoke implementation for amdgcn.

ABataev added inline comments.Dec 6 2019, 6:30 AM
openmp/libomptarget/deviceRTLs/common/src/parallel.cu
1

GPU OpenMP parallel implementation?

  • update comment
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptDec 6 2019, 7:14 AM
  • update comment
JonChesterfield removed projects: Restricted Project, Restricted Project, Restricted Project.Dec 6 2019, 7:17 AM
JonChesterfield removed subscribers: ormris, MatzeB, qcolombet and 15 others.
ABataev added inline comments.Dec 6 2019, 7:18 AM
openmp/libomptarget/deviceRTLs/common/src/support.cu
1

Same here, GPU

openmp/libomptarget/deviceRTLs/common/src/sync.cu
1

GPU

JonChesterfield marked an inline comment as done.Dec 6 2019, 7:18 AM

Update comment, then fix the fallout from arc diff master --update using an out of date master. Apologies to everyone who was transiently subscribed to this.

  • Update two more comments as requested
JonChesterfield marked 2 inline comments as done.Dec 6 2019, 7:20 AM
This revision is now accepted and ready to land.Dec 6 2019, 7:25 AM
This revision was automatically updated to reflect the committed changes.