Page MenuHomePhabricator

[NFC] Slightly improve wording in the comments
ClosedPublic

Authored by kbobyrev on Dec 3 2019, 12:54 AM.

Diff Detail

Event Timeline

kbobyrev created this revision.Dec 3 2019, 12:54 AM
hokein accepted this revision.Dec 3 2019, 1:05 AM

thanks.

clang-tools-extra/clangd/refactor/Rename.cpp
88

I slightly prefer the lower case, but up to you.

This revision is now accepted and ready to land.Dec 3 2019, 1:05 AM
kbobyrev marked an inline comment as done.Dec 3 2019, 1:10 AM
kbobyrev added inline comments.
clang-tools-extra/clangd/refactor/Rename.cpp
88

Yes, right, I'm slightly confused about it :( There are numerous lower-case FIXME-s and a lot of upper-case ones, too. IIUC, the prevalent style in the llvm/ itself is upper-case, but there's no entry in the codestyle on that.

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2019, 1:19 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript